From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50713 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN9xt-0001Ei-8p for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:04:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN9xs-00039Q-2h for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:04:44 -0500 Received: from mail-qy0-f180.google.com ([209.85.216.180]:34043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN9xr-00039K-UH for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:04:44 -0500 Received: by qyk29 with SMTP id 29so5523946qyk.4 for ; Mon, 29 Nov 2010 12:04:43 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101129195453.GP8544@codesourcery.com> References: <1290538431-13170-1-git-send-email-peter.maydell@linaro.org> <1290538431-13170-9-git-send-email-peter.maydell@linaro.org> <20101129174928.GE8544@codesourcery.com> <20101129195453.GP8544@codesourcery.com> Date: Mon, 29 Nov 2010 20:04:42 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org On 29 November 2010 19:54, Nathan Froyd wrote: > On Mon, Nov 29, 2010 at 07:25:18PM +0000, Peter Maydell wrote: >> (b) add to and extend the softfloat API whenever you have some >> floating-point related thing it doesn't currently support > > I think this is the best approach whenever possible. =C2=A0I would not be= too > worried about the third-party-ness of softfloat; it's extremely stable, > unlikely to change anytime in the near or far future, and we've already > extended in it non-trivial ways anyway. OK. Do we care about maintaining consistency of the API between softfloat and softfloat-native (the latter used only on x86, x86_64, cris, sh4, sh4eb)? I didn't in these patchsets because there didn't seem any point adding functions to softfloat-native that weren't going to be used by anything and so couldn't be tested. >> (c) do something suboptimal where the softfloat API provides >> some-API-but-not-quite-the-ideal-API (which I'm not particularly >> keen on and is what I see the "is_nan() || is_signalling_nan()" >> approach as) > > Yes, this is ugly. =C2=A0Are you up for running: > > =C2=A0perl -p -i -e 's/float(\d+)_is_nan/float\1_is_quiet_nan/g' target-*= /*.c > > (and also carefully in fpu/*) or similar and moving the bit-twiddling > float_is_nan into fpu/? I'm happy to produce a patch doing that if it will be committed :-) -- PMM