From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41857 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJsDV-0003Ig-CM
	for qemu-devel@nongnu.org; Sat, 20 Nov 2010 13:31:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PJsDU-0008VE-CL
	for qemu-devel@nongnu.org; Sat, 20 Nov 2010 13:31:17 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:42289)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PJsDU-0008Up-7z
	for qemu-devel@nongnu.org; Sat, 20 Nov 2010 13:31:16 -0500
Received: by wwb13 with SMTP id 13so198063wwb.10
	for <qemu-devel@nongnu.org>; Sat, 20 Nov 2010 10:31:15 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <8E25C0D9-8F6A-4B4C-BC08-EAD9A4654A8F@web.de>
References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com>
	<7BADF5D6-2BE4-4F2B-A241-24D6BD45DD8E@web.de>
	<AANLkTimcDQEnqtHD76S0NPWsgB_z3raP0uCk+2yRDnvb@mail.gmail.com>
	<8E25C0D9-8F6A-4B4C-BC08-EAD9A4654A8F@web.de>
Date: Sat, 20 Nov 2010 18:31:15 +0000
Message-ID: <AANLkTimMqELiiMQ-5114RMhx5vpgsmfY6aC6vkgv656U@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't
	link qemu-img against NBD objects
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Sat, Nov 20, 2010 at 6:04 PM, Andreas F=E4rber <andreas.faerber@web.de> =
wrote:
> Am 20.11.2010 um 18:39 schrieb Stefan Hajnoczi:
>
>> On Sat, Nov 20, 2010 at 5:22 PM, Andreas F=E4rber <andreas.faerber@web.d=
e>
>> wrote:
>>>
>>> Any plans for a way to disable NBD build completely? There are warnings
>>> about use of daemon() on Mac OS X and possibly Solaris, and there's
>>> little
>>> point in building qemu-nbd if one does not use it.
>>
>> daemon() could be replaced by sharing os_daemonize().
>>
>> What is the warning message that you get?
>
> =A0CC =A0 =A0qemu-nbd.o
> /Users/andreas/QEMU/qemu/qemu-nbd.c: In function =91main=92:
> /Users/andreas/QEMU/qemu/qemu-nbd.c:364: warning: =91daemon=92 is depreca=
ted
> (declared at /usr/include/stdlib.h:283)
>
> http://developer.apple.com/library/mac/#documentation/Darwin/Reference/Ma=
nPages/man3/daemon.3.html

Deprecated in favor of using launchd.

Removing qemu-nbd from the build because there is warning isn't a good
strategy.  You may not use qemu-io either but it is always built.
That's important because otherwise it could bitrot, no one would
notice, and one day qemu-tools wouldn't work on Mac OSX at all
anymore.  Instead we should fix the code that causes a warning.

Is it cheating much to daemonize manually in qemu-nbd? ;)

Stefan