From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46844 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTHwQ-000661-1Y for qemu-devel@nongnu.org; Thu, 16 Dec 2010 12:48:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTHwO-0001nF-UK for qemu-devel@nongnu.org; Thu, 16 Dec 2010 12:48:34 -0500 Received: from mail-ew0-f45.google.com ([209.85.215.45]:48848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTHwO-0001my-Lv for qemu-devel@nongnu.org; Thu, 16 Dec 2010 12:48:32 -0500 Received: by ewy10 with SMTP id 10so2149491ewy.4 for ; Thu, 16 Dec 2010 09:48:31 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1292510661-16106-1-git-send-email-kwolf@redhat.com> References: <1292510360-15707-1-git-send-email-kwolf@redhat.com> <1292510661-16106-1-git-send-email-kwolf@redhat.com> Date: Thu, 16 Dec 2010 17:48:31 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH v2] Remove NULL checks for bdrv_new return value From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Dec 16, 2010 at 2:44 PM, Kevin Wolf wrote: > It's an indirect call to qemu_malloc, which never returns an error. > > Signed-off-by: Kevin Wolf > --- > > v2: > - Fixed bdrv_open failure case in xen_disk > > =A0hw/xen_disk.c | =A0 17 ++++++----------- > =A0qemu-img.c =A0 =A0| =A0 =A05 +---- > =A0qemu-io.c =A0 =A0 | =A0 =A02 -- > =A0qemu-nbd.c =A0 =A0| =A0 =A02 -- > =A04 files changed, 7 insertions(+), 19 deletions(-) Reviewed-by: Stefan Hajnoczi