From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32872 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PvoDZ-0005ii-Hg
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 04:56:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PvoDU-0001v6-Ij
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 04:56:09 -0500
Received: from mail-vx0-f173.google.com ([209.85.220.173]:51454)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PvoDU-0001rv-G6
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 04:56:04 -0500
Received: by mail-vx0-f173.google.com with SMTP id 41so2912151vxb.4
	for <qemu-devel@nongnu.org>; Sat, 05 Mar 2011 01:56:04 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20110301213158.GB7509@laped.lan>
References: <1297982718-21865-1-git-send-email-michael@walle.cc>
	<201102250003.37805.michael@walle.cc> <20110301213158.GB7509@laped.lan>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 5 Mar 2011 11:55:44 +0200
Message-ID: <AANLkTimYBNAhWwksSew7P_OUTOiZhVujVuq6bWbFN8Bb@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 00/17 v3] LatticeMico32 target
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Michael Walle <michael@walle.cc>, Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Tue, Mar 1, 2011 at 11:31 PM, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
> On Fri, Feb 25, 2011 at 12:03:37AM +0100, Michael Walle wrote:
>> Am Donnerstag 17 Februar 2011, 23:45:01 schrieb Michael Walle:
>> > This patchset adds support for the LatticeMico32 softcore processor by
>> > Lattice Semiconductor.
>> >
>> > Changes since v2:
>> > =C2=A0- lots of CODING_STYLE fixes
>> > =C2=A0- reworked pic and juart model, CPUState is not passed anymore
>> > =C2=A0- use qdev reset field instead of qemu_register_reset()
>> > =C2=A0- add missing include guards
>> > =C2=A0- merged lm32_pic_cpu.c into boards file
>> > =C2=A0- removed buggy qemu_irq_lower() in reset functions
>> > =C2=A0- converted hw_error to error_report()
>> >
>> > Changes since v1:
>> > =C2=A0- removed variables which are no longer in use
>> > =C2=A0- replaced some tcg ops with specialized ones
>> > =C2=A0- kill VM in case of an unknown opcode
>> > =C2=A0- fixed tracepoints format strings to match existing ones
>>
>> Any comments/reviews on this patchset?
>>
>> I've changed the opcode decoding to use a lookup table instead of the fo=
r-
>> loop. If you don't mind, i would submit a patch after the above is merge=
d. Or,
>> alternatively, if there is another patchset version, i'll integrate it i=
nto
>> that ;)
>
> Hi, lets do v3 first.
>
> Do you have a public tree to pull from?
>
> Blue, did v3 address all the comments you had?

Yes, it looks OK.