From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33179 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q1eDV-00011b-Jm
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:28:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q1eDT-00087G-TE
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:28:12 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:38864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q1eDT-000879-O2
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:28:11 -0400
Received: by yib19 with SMTP id 19so2917205yib.4
	for <qemu-devel@nongnu.org>; Mon, 21 Mar 2011 05:28:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110317172308.GB7413@playa.tlv.redhat.com>
References: <1300373376-13890-1-git-send-email-alevy@redhat.com>
	<1300373376-13890-2-git-send-email-alevy@redhat.com>
	<20110317150052.GX7413@playa.tlv.redhat.com>
	<AANLkTi=2waBmy-E_EOszEv2DMej6550zLnmAB+8NEGNq@mail.gmail.com>
	<20110317172308.GB7413@playa.tlv.redhat.com>
Date: Mon, 21 Mar 2011 12:28:11 +0000
Message-ID: <AANLkTimbs4faaUeghahLwVNh0P2_ejiSSV9S1ZHCLgLG@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v21 01/11] trace: move trace objects from
	Makefile to Makefile.objs
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com
Cc: Alon Levy <alevy@redhat.com>

On Thu, Mar 17, 2011 at 5:23 PM, Alon Levy <alevy@redhat.com> wrote:
> On Thu, Mar 17, 2011 at 04:45:15PM +0000, Stefan Hajnoczi wrote:
>> On Thu, Mar 17, 2011 at 3:00 PM, Alon Levy <alevy@redhat.com> wrote:
>> > On Thu, Mar 17, 2011 at 04:49:26PM +0200, Alon Levy wrote:
>> >> ---
>> >> =A0Makefile =A0 =A0 =A0| =A0 32 --------------------------------
>> >> =A0Makefile.objs | =A0 32 ++++++++++++++++++++++++++++++++
>> >> =A02 files changed, 32 insertions(+), 32 deletions(-)
>> >
>> > The commit message can be a little more verbose :(
>> >
>> > It will be:
>> >
>> > allow libcacard (later commit) to make use of the rules for
>> > building trace objects, to build libcacard/vscclient (and
>> > later still libcacard/libcacard.so).
>>
>> I will test this patch and get back to you within the next two or three =
days.
> Thanks, much appreciated.

$ make distclean
$ ./configure --prefix=3D/usr --target-list=3Dx86_64-softmmu
--enable-io-thread  --disable-strip --enable-trace-backend=3Dsimple
$ make
[...]
  LINK  libcacard/vscclient
simpletrace.o: In function `get_clock':
/home/stefanha/qemu/qemu-timer.h:92: undefined reference to `use_rt_clock'
collect2: ld returned 1 exit status
make[1]: *** [vscclient] Error 1
make: *** [subdir-libcacard] Error 2

Stefan