* [Qemu-devel] [PATCH] checkpatch.pl: don't complain about old lines with tabs
@ 2011-02-03 17:55 Blue Swirl
2011-02-03 21:50 ` [Qemu-devel] " Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2011-02-03 17:55 UTC (permalink / raw)
To: Jan Kiszka, qemu-devel
Don't complain when the patch includes lines with tabs
only in the hunk's untouched context.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4fa06c0..075b614 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1495,7 +1495,7 @@ sub process {
next if ($realfile !~ /\.(h|c|pl)$/);
# in QEMU, no tabs are allowed
- if ($rawline =~ /\t/) {
+ if ($rawline =~ /^\+.*\t/) {
my $herevet = "$here\n" . cat_vet($rawline) . "\n";
ERROR("code indent should never use tabs\n" . $herevet);
$rpt_cleaners = 1;
--
1.6.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] checkpatch.pl: don't complain about old lines with tabs
2011-02-03 17:55 [Qemu-devel] [PATCH] checkpatch.pl: don't complain about old lines with tabs Blue Swirl
@ 2011-02-03 21:50 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2011-02-03 21:50 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On 2011-02-03 18:55, Blue Swirl wrote:
> Don't complain when the patch includes lines with tabs
> only in the hunk's untouched context.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4fa06c0..075b614 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1495,7 +1495,7 @@ sub process {
> next if ($realfile !~ /\.(h|c|pl)$/);
>
> # in QEMU, no tabs are allowed
> - if ($rawline =~ /\t/) {
> + if ($rawline =~ /^\+.*\t/) {
> my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> ERROR("code indent should never use tabs\n" . $herevet);
> $rpt_cleaners = 1;
> -- 1.6.2.4
Works perfectly now.
Thanks,
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-03 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-03 17:55 [Qemu-devel] [PATCH] checkpatch.pl: don't complain about old lines with tabs Blue Swirl
2011-02-03 21:50 ` [Qemu-devel] " Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).