From: Blue Swirl <blauwirbel@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] Re: [RFC v4] Introduce qemu_madvise()
Date: Tue, 14 Sep 2010 16:31:37 +0000 [thread overview]
Message-ID: <AANLkTimdmiuy6TcEuBy-r9OrvuWDJN13WiL12UDSVikm@mail.gmail.com> (raw)
In-Reply-To: <1284413185-2988-1-git-send-email-andreas.faerber@web.de>
On Mon, Sep 13, 2010 at 9:26 PM, Andreas Färber <andreas.faerber@web.de> wrote:
> From: Andreas Färber <afaerber@opensolaris.org>
>
> vl.c has a Sun-specific hack to supply a prototype for madvise(),
> but the call site has apparently moved to arch_init.c.
>
> Haiku doesn't implement madvise() in favor of posix_madvise().
> OpenBSD and Solaris 10 don't implement posix_madvise() but madvise().
>
> Check for madvise() and posix_madvise() in configure and supply qemu_madvise()
> as wrapper. Prefer madvise() over posix_madvise() due to flag availability.
> Convert all callers to use qemu_madvise() and QEMU_MADV_*.
>
> Note that on Solaris the warning is fixed by moving the madvise() prototype,
> not by qemu_madvise() itself. It will help with future porting though.
>
> v3 -> v4:
> * Eliminate #ifdefs at qemu_advise() call sites. Requested by Blue Swirl.
> This will currently break the check in kvm-all.c by calling madvise() with
> a supported flag, which will not fail. Ideas/patches welcome.
Your original switch with synthetic (1<<0, 1<<1 etc) values for
QEMU_MADV_* for all hosts (never reusing MADV_* defines).
next prev parent reply other threads:[~2010-09-14 16:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 17:05 [Qemu-devel] [PATCH] Introduce qemu_madvise() Andreas Färber
2010-09-11 21:37 ` Alexander Graf
2010-09-11 22:39 ` Andreas Färber
2010-09-11 22:47 ` Alexander Graf
2010-09-12 7:20 ` [Qemu-devel] " Blue Swirl
2010-09-12 8:50 ` Andreas Färber
2010-09-12 9:02 ` Blue Swirl
2010-09-12 12:55 ` [Qemu-devel] [PATCH v3] " Andreas Färber
2010-09-12 17:29 ` [Qemu-devel] " Blue Swirl
2010-09-13 12:02 ` Alexander Graf
2010-09-13 21:26 ` [Qemu-devel] [RFC v4] " Andreas Färber
2010-09-14 16:31 ` Blue Swirl [this message]
2010-09-14 16:34 ` [Qemu-devel] " Alexander Graf
2010-09-14 17:10 ` Blue Swirl
2010-09-14 20:28 ` [Qemu-devel] [PATCH v5] " Andreas Färber
2010-09-14 20:36 ` [Qemu-devel] " Blue Swirl
2010-09-14 20:39 ` Andreas Färber
2010-09-15 18:09 ` [Qemu-devel] [PATCH v6] " Andreas Färber
2010-09-15 19:00 ` [Qemu-devel] " Blue Swirl
2010-09-15 19:35 ` Andreas Färber
2010-09-15 19:50 ` Blue Swirl
2010-09-15 20:07 ` Andreas Färber
2010-09-19 10:11 ` [Qemu-devel] [PATCH v7] " Andreas Färber
2010-09-20 20:33 ` [Qemu-devel] " Blue Swirl
2010-09-24 18:08 ` Andreas Färber
2010-09-25 7:49 ` Blue Swirl
2010-09-25 10:58 ` [Qemu-devel] [PATCH v8] " Andreas Färber
2010-09-25 15:17 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimdmiuy6TcEuBy-r9OrvuWDJN13WiL12UDSVikm@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).