* [Qemu-devel] checkpatch.pl false positive: wants braces on #if
@ 2011-02-23 16:07 Peter Maydell
2011-02-25 15:38 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-02-23 16:07 UTC (permalink / raw)
To: QEMU Developers
If you run checkpatch.pl on this patch:
http://patchwork.ozlabs.org/patch/84189/
it complains:
WARNING: braces {} are necessary even for single statement blocks
#29: FILE: tcg/tcg.c:454:
+#if defined(CONFIG_DEBUG_TCG)
+ s->temps_in_use++;
...but braces on a cpp conditional are a bit tricky :-)
The script is sufficiently hairy perl that I'm afraid I
can't suggest a solution, only report the problem.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] checkpatch.pl false positive: wants braces on #if
2011-02-23 16:07 [Qemu-devel] checkpatch.pl false positive: wants braces on #if Peter Maydell
@ 2011-02-25 15:38 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2011-02-25 15:38 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
On Wed, Feb 23, 2011 at 6:07 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> If you run checkpatch.pl on this patch:
> http://patchwork.ozlabs.org/patch/84189/
>
> it complains:
> WARNING: braces {} are necessary even for single statement blocks
> #29: FILE: tcg/tcg.c:454:
> +#if defined(CONFIG_DEBUG_TCG)
> + s->temps_in_use++;
>
>
> ...but braces on a cpp conditional are a bit tricky :-)
>
> The script is sufficiently hairy perl that I'm afraid I
> can't suggest a solution, only report the problem.
Maybe this helps:
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 075b614..4b1e2c2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2537,7 +2537,7 @@ sub process {
}
if (!defined $suppress_ifbraces{$linenr - 1} &&
$line =~ /\b(if|while|for|else)\b/ &&
- $line !~ /\#\s*else/) {
+ $line !~ /\#\s*(if|else|elif)/) {
my $allowed = 0;
# Check the pre-context.
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-25 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 16:07 [Qemu-devel] checkpatch.pl false positive: wants braces on #if Peter Maydell
2011-02-25 15:38 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).