From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54343 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLcvi-00072i-VF
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 09:36:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PLcvh-0001S3-K5
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 09:36:10 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:44466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PLcvh-0001RK-FT
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 09:36:09 -0500
Received: by wwb24 with SMTP id 24so64434wwb.10
	for <qemu-devel@nongnu.org>; Thu, 25 Nov 2010 06:36:08 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1290597370-21365-15-git-send-email-hare@suse.de>
References: <1290597370-21365-1-git-send-email-hare@suse.de>
	<1290597370-21365-15-git-send-email-hare@suse.de>
Date: Thu, 25 Nov 2010 14:36:08 +0000
Message-ID: <AANLkTimfKxutGnDpwZhZYd3dN3h+3e_6rwGFizH3EbRT@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 14/15] megasas: LSI Megaraid SAS emulation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: nab@linux-iscsi.org, qemu-devel@nongnu.org, kraxel@redhat.com

On Wed, Nov 24, 2010 at 11:16 AM, Hannes Reinecke <hare@suse.de> wrote:
> +static int megasas_pd_get_info_submit(SCSIDevice * sdev, int lun,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0struct megasas_cmd_t *cmd)
> +{
> + =A0 =A0struct mfi_pd_info * info =3D cmd->iov_buf;
> + =A0 =A0uint8_t cmdbuf[6];
> + =A0 =A0SCSIRequest *req;
> +
> + =A0 =A0if (info->inquiry_data[4] =3D=3D 0) {
> + =A0 =A0 =A0 =A0/* Additional length is zero, resubmit */
> + =A0 =A0 =A0 =A0megasas_setup_inquiry(cmdbuf, 0, info->inquiry_data,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(info-=
>inquiry_data));
> + =A0 =A0 =A0 =A0req =3D sdev->info->alloc_req(sdev, (uint32_t) -1, lun);
> + =A0 =A0 =A0 =A0if (!req) {
> + =A0 =A0 =A0 =A0 =A0 =A0return MFI_STAT_FLASH_ALLOC_FAIL;
> + =A0 =A0 =A0 =A0}
> + =A0 =A0 =A0 =A0DPRINTF_DCMD("PD get info submit std inquiry to dev %d\n=
", lun);
> + =A0 =A0 =A0 =A0req->hba_private =3D cmd;
> + =A0 =A0 =A0 =A0if (cmd->sdev->info->send_command(req, cmdbuf) > 0)
> + =A0 =A0 =A0 =A0 =A0 =A0cmd->sdev->info->read_data(req);
> + =A0 =A0 =A0 =A0return MFI_STAT_INVALID_STATUS;

Here...

> + =A0 =A0} else if (info->vpd_page83[3] =3D=3D 0) {
> + =A0 =A0 =A0 =A0/* Additional length is zero, resubmit */
> + =A0 =A0 =A0 =A0megasas_setup_inquiry(cmdbuf, 0x83,(uint8_t *)info->vpd_=
page83,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(info-=
>vpd_page83));
> + =A0 =A0 =A0 =A0req =3D sdev->info->alloc_req(sdev, (uint32_t) -1, lun);
> + =A0 =A0 =A0 =A0if (!req) {
> + =A0 =A0 =A0 =A0 =A0 =A0return MFI_STAT_FLASH_ALLOC_FAIL;
> + =A0 =A0 =A0 =A0}
> + =A0 =A0 =A0 =A0DPRINTF_DCMD("PD get info submit vpd inquiry to dev %d\n=
", lun);
> + =A0 =A0 =A0 =A0req->hba_private =3D cmd;
> + =A0 =A0 =A0 =A0if (cmd->sdev->info->send_command(req, cmdbuf) > 0)
> + =A0 =A0 =A0 =A0 =A0 =A0cmd->sdev->info->read_data(req);
> + =A0 =A0 =A0 =A0return MFI_STAT_INVALID_STATUS;

...and here I can't tell for sure if an error status is returned
intentionally or whether this is an if statement without {}-related
bug.

On one hand it looks like it could be intentional.  On the other hand
we went through the trouble of sending an inquiry command that may
have succeeded but we're still returning an error status.

Stefan