Re: [Qemu-devel] Re: [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop()

[Corentin Chary <corentin.chary@gmail.com>]

On Thu, Jun 3, 2010 at 9:27 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 05/29/2010 09:38 AM, Corentin Chary wrote:
>>
>> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
>> ---
>>  qemu-thread.h |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-thread.h b/qemu-thread.h
>> index 19bb30c..e5006bb 100644
>> --- a/qemu-thread.h
>> +++ b/qemu-thread.h
>> @@ -41,4 +41,8 @@ void qemu_thread_self(QemuThread *thread);
>>  int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2);
>>  void qemu_thread_exit(void *retval);
>>
>> +#define qemu_thread_cleanup_pop(execute) pthread_cleanup_pop(execute)
>> +#define qemu_thread_cleanup_push(routine, arg)  \
>> +    pthread_cleanup_push(routine, arg)
>
> I agree with Paul that this isn't necessary.  Also you're not using
> pthread_exit.  Probably stale from a previous version of the patch?

Right pthread_exit() is missing.

Anyway, I don't use thread cancellation in the threaded vnc server (I
send a signal to the condition with an empty queue to stop the
thread), so we can skip this patch.



-- 
Corentin Chary
http://xf.iksaif.net