From: Blue Swirl <blauwirbel@gmail.com>
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc: use bswapNN() rather than bswap_NN()
Date: Sat, 4 Sep 2010 10:12:37 +0000 [thread overview]
Message-ID: <AANLkTimo2VuJS0xbHwhFTkZB7VrgXgGBKXru6Ku=zNrp@mail.gmail.com> (raw)
In-Reply-To: <1281261245-12228-1-git-send-email-tsutsui@ceres.dti.ne.jp>
Thanks, applied.
On Sun, Aug 8, 2010 at 9:54 AM, Izumi Tsutsui <tsutsui@ceres.dti.ne.jp> wrote:
> bswap_NN() variants are not always available in CONFIG_MACHINE_BSWAP_H case
> and bswapNN() are public APIs in "bswap.h".
>
> Signed-off-by: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
> ---
> ui/vnc-enc-tight.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index c4c9c3b..d229d22 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -209,7 +209,7 @@ tight_detect_smooth_image24(VncState *vs, int w, int h)
> d < w - x - VNC_TIGHT_DETECT_SUBROW_WIDTH; d++) { \
> pix = ((uint##bpp##_t *)buf)[(y+d)*w+x+d]; \
> if (endian) { \
> - pix = bswap_##bpp(pix); \
> + pix = bswap##bpp(pix); \
> } \
> for (c = 0; c < 3; c++) { \
> left[c] = (int)(pix >> shift[c] & max[c]); \
> @@ -218,7 +218,7 @@ tight_detect_smooth_image24(VncState *vs, int w, int h)
> dx++) { \
> pix = ((uint##bpp##_t *)buf)[(y+d)*w+x+d+dx]; \
> if (endian) { \
> - pix = bswap_##bpp(pix); \
> + pix = bswap##bpp(pix); \
> } \
> sum = 0; \
> for (c = 0; c < 3; c++) { \
> @@ -608,7 +608,7 @@ tight_filter_gradient24(VncState *vs, uint8_t *buf, int w, int h)
> for (x = 0; x < w; x++) { \
> pix = *buf; \
> if (endian) { \
> - pix = bswap_##bpp(pix); \
> + pix = bswap##bpp(pix); \
> } \
> diff = 0; \
> for (c = 0; c < 3; c++) { \
> @@ -628,7 +628,7 @@ tight_filter_gradient24(VncState *vs, uint8_t *buf, int w, int h)
> << shift[c]; \
> } \
> if (endian) { \
> - diff = bswap_##bpp(diff); \
> + diff = bswap##bpp(diff); \
> } \
> *buf++ = diff; \
> } \
> --
> 1.7.0.5
>
>
>
prev parent reply other threads:[~2010-09-04 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 9:54 [Qemu-devel] [PATCH] vnc: use bswapNN() rather than bswap_NN() Izumi Tsutsui
2010-09-04 10:12 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimo2VuJS0xbHwhFTkZB7VrgXgGBKXru6Ku=zNrp@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=tsutsui@ceres.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).