qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] trace: improve info trace output
@ 2010-10-17  8:05 Blue Swirl
  2010-10-18 10:27 ` [Qemu-devel] " Stefan Hajnoczi
  0 siblings, 1 reply; 3+ messages in thread
From: Blue Swirl @ 2010-10-17  8:05 UTC (permalink / raw)
  To: qemu-devel, Stefan Hajnoczi

Use PRI*64 to print full 64 bit data even on ILP32 hosts.

Print also sixth tracepoint parameter.

Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 simpletrace.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/simpletrace.c b/simpletrace.c
index deb1e07..b488d51 100644
--- a/simpletrace.c
+++ b/simpletrace.c
@@ -214,9 +214,11 @@ void st_print_trace(FILE *stream, int
(*stream_printf)(FILE *stream, const char
     unsigned int i;

     for (i = 0; i < trace_idx; i++) {
-        stream_printf(stream, "Event %lu : %lx %lx %lx %lx %lx\n",
+        stream_printf(stream, "Event %" PRIu64 " : %" PRIx64 " %" PRIx64
+                      " %" PRIx64 " %" PRIx64 " %" PRIx64 " %" PRIx64 "\n",
                       trace_buf[i].event, trace_buf[i].x1, trace_buf[i].x2,
-                      trace_buf[i].x3, trace_buf[i].x4, trace_buf[i].x5);
+                      trace_buf[i].x3, trace_buf[i].x4, trace_buf[i].x5,
+                      trace_buf[i].x6);
     }
 }

-- 
1.6.2.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Qemu-devel] Re: [PATCH] trace: improve info trace output
  2010-10-17  8:05 [Qemu-devel] [PATCH] trace: improve info trace output Blue Swirl
@ 2010-10-18 10:27 ` Stefan Hajnoczi
  2010-10-20 16:48   ` Blue Swirl
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2010-10-18 10:27 UTC (permalink / raw)
  To: Blue Swirl; +Cc: qemu-devel

On Sun, Oct 17, 2010 at 08:05:45AM +0000, Blue Swirl wrote:
> Use PRI*64 to print full 64 bit data even on ILP32 hosts.
> 
> Print also sixth tracepoint parameter.
> 
> Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  simpletrace.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] Re: [PATCH] trace: improve info trace output
  2010-10-18 10:27 ` [Qemu-devel] " Stefan Hajnoczi
@ 2010-10-20 16:48   ` Blue Swirl
  0 siblings, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2010-10-20 16:48 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel

Thanks for the Ack, applied.

On Mon, Oct 18, 2010 at 10:27 AM, Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com> wrote:
> On Sun, Oct 17, 2010 at 08:05:45AM +0000, Blue Swirl wrote:
>> Use PRI*64 to print full 64 bit data even on ILP32 hosts.
>>
>> Print also sixth tracepoint parameter.
>>
>> Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>>  simpletrace.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-20 16:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-17  8:05 [Qemu-devel] [PATCH] trace: improve info trace output Blue Swirl
2010-10-18 10:27 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-20 16:48   ` Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).