From: Peter Maydell <peter.maydell@linaro.org>
To: Christophe Lyon <christophe.lyon@st.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.
Date: Mon, 21 Feb 2011 12:04:02 +0000 [thread overview]
Message-ID: <AANLkTimps8H690HvzhW7TKFJnbDO8VLCvbDXYCotbKr6@mail.gmail.com> (raw)
In-Reply-To: <1298285975-1717-6-git-send-email-christophe.lyon@st.com>
On 21 February 2011 10:59, Christophe Lyon <christophe.lyon@st.com> wrote:
> + if (float32_is_any_nan(a)) {
> + if (float32_is_signaling_nan(a)) {
> + float_raise(float_flag_invalid, s);
> + }
> + return float32_maybe_silence_nan(a);
Wrong answer for NaNs, fix as per comments in other patch.
> + if ((a & 0xc0000000) == 0) return 0xffffffff;
if (cond) {
return thing;
}
please, as per coding style. (Sorry, should have spotted
that in the review pass for earlier versions.)
-- PMM
next prev parent reply other threads:[~2011-02-21 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 10:59 [Qemu-devel] [PATCH v5 0/5] ARM: fix Neon VRECPE and VRSQRTE instructions Christophe Lyon
2011-02-21 10:59 ` [Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h Christophe Lyon
2011-02-21 11:55 ` Peter Maydell
2011-02-21 10:59 ` [Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats Christophe Lyon
2011-02-21 11:57 ` Peter Maydell
2011-02-21 10:59 ` [Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants Christophe Lyon
2011-02-21 11:59 ` Peter Maydell
2011-02-21 10:59 ` [Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE Christophe Lyon
2011-02-21 11:53 ` Peter Maydell
2011-02-21 10:59 ` [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE Christophe Lyon
2011-02-21 12:04 ` Peter Maydell [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-21 16:38 [Qemu-devel] [PATCH v6 0/5] ARM: fix Neon VRECPE and VRSQRTE instructions Christophe Lyon
2011-02-21 16:38 ` [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE Christophe Lyon
2011-02-22 11:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimps8H690HvzhW7TKFJnbDO8VLCvbDXYCotbKr6@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=christophe.lyon@st.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).