From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34547 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PrUUm-0006jJ-SS
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:04:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PrUUl-0006yp-OT
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:04:04 -0500
Received: from mail-ew0-f52.google.com ([209.85.215.52]:38344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PrUUl-0006yc-IW
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:04:03 -0500
Received: by ewy10 with SMTP id 10so462788ewy.11
	for <qemu-devel@nongnu.org>; Mon, 21 Feb 2011 04:04:02 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1298285975-1717-6-git-send-email-christophe.lyon@st.com>
References: <1298285975-1717-1-git-send-email-christophe.lyon@st.com>
	<1298285975-1717-6-git-send-email-christophe.lyon@st.com>
Date: Mon, 21 Feb 2011 12:04:02 +0000
Message-ID: <AANLkTimps8H690HvzhW7TKFJnbDO8VLCvbDXYCotbKr6@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Lyon <christophe.lyon@st.com>
Cc: qemu-devel@nongnu.org

On 21 February 2011 10:59, Christophe Lyon <christophe.lyon@st.com> wrote:
> + =C2=A0 =C2=A0if (float32_is_any_nan(a)) {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (float32_is_signaling_nan(a)) {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0float_raise(float_flag_invalid=
, s);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0return float32_maybe_silence_nan(a);

Wrong answer for NaNs, fix as per comments in other patch.

> + =C2=A0 =C2=A0if ((a & 0xc0000000) =3D=3D 0) return 0xffffffff;

if (cond) {
    return thing;
}

please, as per coding style. (Sorry, should have spotted
that in the review pass for earlier versions.)

-- PMM