From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49594 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pdq8M-0004pk-0v for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:20:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pdq65-0007vf-7Z for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:18:10 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:48296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pdq65-0007va-2x for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:18:09 -0500 Received: by pzk2 with SMTP id 2so593236pzk.4 for ; Fri, 14 Jan 2011 12:18:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1295032341-6926-3-git-send-email-daahern@cisco.com> References: <1295032341-6926-1-git-send-email-daahern@cisco.com> <1295032341-6926-3-git-send-email-daahern@cisco.com> From: Blue Swirl Date: Fri, 14 Jan 2011 20:17:46 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: qemu-devel@nongnu.org On Fri, Jan 14, 2011 at 7:12 PM, David Ahern wrote: > Currently, device config settings in the default-configs file are not propogated into the config*.h files. While the Makefile rules observe them through the *.mak files, the CONFIG options are not usable within the .c files. > > This patch adds the settings to the header files. To do that the host devices make file is renamed to config-host-devices.mak and the target devices mak file to config-target-devices.mak. NACK, see this thread for the previous discussion: http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg02268.html