From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Force object directory use
Date: Tue, 16 Nov 2010 22:37:44 +0000 [thread overview]
Message-ID: <AANLkTimubK4fX8Pf-8NbkkPbJ6M6YBi_TXBvwQ3hdfCs@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikG6irnzidq-UMFyqLTUoqPR8EUo-M=+soM4jhZ@mail.gmail.com>
On 16 November 2010 21:59, Blue Swirl <blauwirbel@gmail.com> wrote:
> If the user attempts to run 'configure' in the source tree,
> create an object directory and configure that instead.
>
> Rename topmost Makefile to Makefile.top. Add a new Makefile, which
> is only used when user attempts to run 'make' in the source tree.
[Something seems to have line-wrapped this patch so it won't
apply (not just me, http://patchwork.ozlabs.org/patch/71463/
has line-wrap damage too).]
Minor nit: I think the patch as it stands breaks the "Please
call configure before running make!" user-error guard, doesn't
it?
-- PMM
next prev parent reply other threads:[~2010-11-16 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 21:59 [Qemu-devel] [PATCH] Force object directory use Blue Swirl
2010-11-16 22:18 ` Anthony Liguori
2010-11-16 22:37 ` Peter Maydell [this message]
2010-11-17 19:08 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimubK4fX8Pf-8NbkkPbJ6M6YBi_TXBvwQ3hdfCs@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).