From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50005 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIU9r-0003pG-KE for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:37:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIU9q-0003G7-Hj for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:37:47 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:57372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIU9q-0003G1-EO for qemu-devel@nongnu.org; Tue, 16 Nov 2010 17:37:46 -0500 Received: by qwi2 with SMTP id 2so476409qwi.4 for ; Tue, 16 Nov 2010 14:37:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 16 Nov 2010 22:37:44 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH] Force object directory use From: Peter Maydell Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 16 November 2010 21:59, Blue Swirl wrote: > If the user attempts to run 'configure' in the source tree, > create an object directory and configure that instead. > > Rename topmost Makefile to Makefile.top. Add a new Makefile, which > is only used when user attempts to run 'make' in the source tree. [Something seems to have line-wrapped this patch so it won't apply (not just me, http://patchwork.ozlabs.org/patch/71463/ has line-wrap damage too).] Minor nit: I think the patch as it stands breaks the "Please call configure before running make!" user-error guard, doesn't it? -- PMM