From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45575 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8ZoD-0007AC-Dq
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 10:38:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1P8ZoC-0007pT-CD
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 10:38:29 -0400
Received: from mail-ey0-f173.google.com ([209.85.215.173]:57032)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1P8ZoC-0007pE-6f
	for qemu-devel@nongnu.org; Wed, 20 Oct 2010 10:38:28 -0400
Received: by eyb6 with SMTP id 6so671217eyb.4
	for <qemu-devel@nongnu.org>; Wed, 20 Oct 2010 07:38:27 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1287583790-9349-1-git-send-email-berrange@redhat.com>
References: <1287583790-9349-1-git-send-email-berrange@redhat.com>
Date: Wed, 20 Oct 2010 15:36:57 +0100
Message-ID: <AANLkTimyL65RDSFDdMbdkeibw4n2MAHuMXp4XacSq5sW@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] Add a DTrace tracing backend targetted
	for SystemTAP compatability
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Oct 20, 2010 at 3:09 PM, Daniel P. Berrange <berrange@redhat.com> w=
rote:
> @@ -2175,6 +2175,16 @@ EOF
> =A0 =A0 exit 1
> =A0 fi
> =A0fi
> +
> +##########################################
> +# For 'dtrace' backend, test if 'dtrace' command is present
> +if ! has 'dtrace' ; then
> + =A0echo
> + =A0echo "Error: dtrace command is not found in PATH $PATH"
> + =A0echo
> + =A0exit 1
> +fi
> +
> =A0##########################################
> =A0# End of CC checks
> =A0# After here, no more $cc or $ld runs

This doesn't seem to check that [ "$trace_backend" =3D "dtrace" ] and
will break ./configure on boxes without dtrace even when
--trace-backend=3Ddtrace is not used.

Stefan