From: Blue Swirl <blauwirbel@gmail.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v4 0/9] Re-factor osdep code + macro and brace fixes
Date: Sat, 30 Oct 2010 09:23:49 +0000 [thread overview]
Message-ID: <AANLkTimyUnQE9noP4rRrg2a1S3ro4xEfYyng9rSsY4Oe@mail.gmail.com> (raw)
In-Reply-To: <1288082367-27944-1-git-send-email-Jes.Sorensen@redhat.com>
Thanks, applied all.
On Tue, Oct 26, 2010 at 8:39 AM, <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Hi,
>
> Here is another set of patches which tries to split up osdep.c further
> into posix and win32 versions. It introduces oslib-{posix,win32}.c
> files which are used for functions that are OS specific core library
> functionality, like gettimeofday(), and which is used by both QEMU and
> support applications like qemu-img. Other functions are moved to
> os-{posix,win32}.c. In addtion there are a couple of minor fixes for
> bad macro names.
>
> In some cases braces were added to code when it was moved, to make it
> compliant with the QEMU bracing rules.
>
> v4 fixes the build problem for m68k-linux-user reported by Blue Swirl.
>
> Cheers,
> Jes
>
>
> Jes Sorensen (9):
> Move QEMU OS dependant library functions to OS specific files
> Move osdep socket code to oslib-{posix,win32}.c
> qemu_pipe() is used only by POSIX code, so move to oslib-posix.c
> We only support eventfd under POSIX, move qemu_eventfd() to
> os-posix.c
> Move qemu_gettimeofday() to OS specific files
> Do not redefine reserved key-words TRUE/FALSE
> Separate qemu_pidfile() into OS specific versions
> Consolidate oom_check() functions
> Remove unncessary includes
>
> Makefile | 6 +-
> Makefile.objs | 9 ++-
> Makefile.target | 2 +-
> hw/bt-sdp.c | 20 ++--
> m68k-semi.c | 2 +-
> os-posix.c | 53 +++++++++++
> os-win32.c | 24 +++++
> osdep.c | 256 ----------------------------------------------------
> osdep.h | 15 ---
> oslib-posix.c | 109 ++++++++++++++++++++++
> oslib-win32.c | 121 +++++++++++++++++++++++++
> posix-aio-compat.c | 1 +
> qemu-common.h | 6 ++
> qemu-img.c | 1 +
> qemu-malloc.c | 14 +---
> qemu-os-posix.h | 3 +
> qemu-os-win32.h | 8 ++
> qemu-tool.c | 1 +
> 18 files changed, 353 insertions(+), 298 deletions(-)
> create mode 100644 oslib-posix.c
> create mode 100644 oslib-win32.c
>
> --
> 1.7.2.3
>
>
prev parent reply other threads:[~2010-10-30 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 8:39 [Qemu-devel] [PATCH v4 0/9] Re-factor osdep code + macro and brace fixes Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 2/9] Move osdep socket code to oslib-{posix, win32}.c Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to oslib-posix.c Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions Jes.Sorensen
2010-10-26 8:39 ` [Qemu-devel] [PATCH 9/9] Remove unncessary includes Jes.Sorensen
2010-10-30 9:23 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimyUnQE9noP4rRrg2a1S3ro4xEfYyng9rSsY4Oe@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).