From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50553 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PC7fW-000164-L1 for qemu-devel@nongnu.org; Sat, 30 Oct 2010 05:24:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PC7fV-0007fT-Jg for qemu-devel@nongnu.org; Sat, 30 Oct 2010 05:24:10 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:63595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PC7fV-0007Wm-Dl for qemu-devel@nongnu.org; Sat, 30 Oct 2010 05:24:09 -0400 Received: by mail-vw0-f45.google.com with SMTP id 4so1066647vws.4 for ; Sat, 30 Oct 2010 02:24:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1288082367-27944-1-git-send-email-Jes.Sorensen@redhat.com> References: <1288082367-27944-1-git-send-email-Jes.Sorensen@redhat.com> From: Blue Swirl Date: Sat, 30 Oct 2010 09:23:49 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH v4 0/9] Re-factor osdep code + macro and brace fixes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org Thanks, applied all. On Tue, Oct 26, 2010 at 8:39 AM, wrote: > From: Jes Sorensen > > Hi, > > Here is another set of patches which tries to split up osdep.c further > into posix and win32 versions. It introduces oslib-{posix,win32}.c > files which are used for functions that are OS specific core library > functionality, like gettimeofday(), and which is used by both QEMU and > support applications like qemu-img. Other functions are moved to > os-{posix,win32}.c. In addtion there are a couple of minor fixes for > bad macro names. > > In some cases braces were added to code when it was moved, to make it > compliant with the QEMU bracing rules. > > v4 fixes the build problem for m68k-linux-user reported by Blue Swirl. > > Cheers, > Jes > > > Jes Sorensen (9): > =C2=A0Move QEMU OS dependant library functions to OS specific files > =C2=A0Move osdep socket code to oslib-{posix,win32}.c > =C2=A0qemu_pipe() is used only by POSIX code, so move to oslib-posix.c > =C2=A0We only support eventfd under POSIX, move qemu_eventfd() to > =C2=A0 =C2=A0os-posix.c > =C2=A0Move qemu_gettimeofday() to OS specific files > =C2=A0Do not redefine reserved key-words TRUE/FALSE > =C2=A0Separate qemu_pidfile() into OS specific versions > =C2=A0Consolidate oom_check() functions > =C2=A0Remove unncessary includes > > =C2=A0Makefile =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A06 +- > =C2=A0Makefile.objs =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A09 ++- > =C2=A0Makefile.target =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- > =C2=A0hw/bt-sdp.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 20 ++-- > =C2=A0m68k-semi.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- > =C2=A0os-posix.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 53 +++++++++++ > =C2=A0os-win32.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 24 +++++ > =C2=A0osdep.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0256 ------= ---------------------------------------------- > =C2=A0osdep.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 15 --- > =C2=A0oslib-posix.c =C2=A0 =C2=A0 =C2=A0| =C2=A0109 +++++++++++++++++++++= + > =C2=A0oslib-win32.c =C2=A0 =C2=A0 =C2=A0| =C2=A0121 +++++++++++++++++++++= ++++ > =C2=A0posix-aio-compat.c | =C2=A0 =C2=A01 + > =C2=A0qemu-common.h =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A06 ++ > =C2=A0qemu-img.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A01 + > =C2=A0qemu-malloc.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 14 +--- > =C2=A0qemu-os-posix.h =C2=A0 =C2=A0| =C2=A0 =C2=A03 + > =C2=A0qemu-os-win32.h =C2=A0 =C2=A0| =C2=A0 =C2=A08 ++ > =C2=A0qemu-tool.c =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A01 + > =C2=A018 files changed, 353 insertions(+), 298 deletions(-) > =C2=A0create mode 100644 oslib-posix.c > =C2=A0create mode 100644 oslib-win32.c > > -- > 1.7.2.3 > >