From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49869 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4GSi-0007cJ-Km
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:42:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q4GSh-0006t1-20
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:42:43 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:56659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q4GSg-0006su-Ti
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 13:42:43 -0400
Received: by vws17 with SMTP id 17so2830001vws.4
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 10:42:42 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <AANLkTimnjLQPnOZ_Xe7Bq80ZFZa+f69JrxAbLY1ShQb4@mail.gmail.com>
References: <1301319862-22998-1-git-send-email-peter.maydell@linaro.org>
	<1301319862-22998-4-git-send-email-peter.maydell@linaro.org>
	<AANLkTimnjLQPnOZ_Xe7Bq80ZFZa+f69JrxAbLY1ShQb4@mail.gmail.com>
Date: Mon, 28 Mar 2011 18:36:37 +0100
Message-ID: <AANLkTin-HpyhPrWmTWkgCcpuu51c6UcGpfyzerVy5TkR@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH v2 3/5] hw/sun4m: Move QEMUMachine structs
 into sun4*_hwdef structs
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 28 March 2011 18:31, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Mon, Mar 28, 2011 at 4:44 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Combine the per-machine QEMUMachine struct into the per-machine
>> sun4*_hwdef struct. This requires some moving around of init functions
>> to avoid forward references. We also have to move the 'const'
>> attribute from the whole sun4*_hwdef[] array to the individual fields
>> of the structure, because QEMUMachine is not const.
>
> Maybe QEMUMachine should be made const instead? The data does not ever
> need to change.

I thought about that, but we need to fill in the 'next' links when
we do qemu_register_device().

(vl.c also sets machine->max_cpus if it wasn't set. I don't think
anything else modifies QEMUMachine structure fields.)

-- PMM