From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38398 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ojw5Q-00078K-Ok for qemu-devel@nongnu.org; Fri, 13 Aug 2010 11:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ojw5H-0002Fr-PE for qemu-devel@nongnu.org; Fri, 13 Aug 2010 11:22:24 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:51199) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ojw5H-0002FW-LL for qemu-devel@nongnu.org; Fri, 13 Aug 2010 11:22:15 -0400 Received: by wyi11 with SMTP id 11so2907814wyi.4 for ; Fri, 13 Aug 2010 08:22:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 13 Aug 2010 12:22:13 -0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments From: Miguel Di Ciurcio Filho Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Blue Swirl , qemu-devel On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: > > While intentions of this are good, i believe this goes too far, i doubt > that the proposed additions are enforcable and have no doubts that they > will be widely ignored and at the same time provide more grounds for > whining. Furthermore the existing code doesn't follow them, going out on > a limb, it's more likely that one would look around the code he/she > modifies and base his/her modifications on the surrounding code than to > follow the style that conflicts with it. The existing code that I have touched don't follow the current coding style guidance, much less all the new recommendations being suggested. Although, I do believe that this situation needs to change. If we agree in a coding style, I would volunteer to be a some kind of observer to fix and alert people about coding styles mistakes. Regards, Miguel