From: Stefan Hajnoczi <stefanha@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com
Subject: [Qemu-devel] Re: [PATCH] scsi: Implement alloc_req_iov callback
Date: Mon, 22 Nov 2010 21:48:42 +0000 [thread overview]
Message-ID: <AANLkTin85oLpJrj5+BM09e=zedxAvU-e-cusmyP49u4j@mail.gmail.com> (raw)
In-Reply-To: <20101122101536.2B09BF90AF@ochil.suse.de>
On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke <hare@suse.de> wrote:
Looks good. If you send out another version of the patchset you might
like to fix this nitpick:
> + if (!r->io_header.iovec_count) {
> + if (r->buflen != r->req.cmd.xfer) {
> + if (r->buf != NULL)
> + qemu_free(r->buf);
qemu_free(NULL) is a nop so it's safe to drop the if (r->buf != NULL)
check and just use qemu_free(r->buf) unconditionally. That's nice
since it also fixes the if statement without curly braces.
Stefan
next prev parent reply other threads:[~2010-11-22 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 10:15 [Qemu-devel] [PATCH] scsi: Implement alloc_req_iov callback Hannes Reinecke
2010-11-22 21:48 ` Stefan Hajnoczi [this message]
2010-11-23 8:12 ` [Qemu-devel] " Hannes Reinecke
2010-11-23 8:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin85oLpJrj5+BM09e=zedxAvU-e-cusmyP49u4j@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).