qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: TeLeMan <geleman@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] Re: [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate
Date: Sat, 5 Jun 2010 08:46:48 +0800	[thread overview]
Message-ID: <AANLkTinAMvZo2hAgJWbQQTVisaVPsdnQsl7JSb2nACwH@mail.gmail.com> (raw)
In-Reply-To: <AANLkTindZKR6M_OHQpzd5uV6xxr8ZzeyppryAzAM4ZaZ@mail.gmail.com>

no comments?

On Tue, Jun 1, 2010 at 12:26, TeLeMan <geleman@gmail.com> wrote:
> The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced
> expire_time of UHCIState. But expire_time is not in vmstate, the
> second uhci_frame_timer will not be fired immediately after loadvm.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
>  hw/usb-uhci.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 624d55b..d9d74c9 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -375,7 +375,7 @@ static const VMStateDescription vmstate_uhci_port = {
>
>  static const VMStateDescription vmstate_uhci = {
>     .name = "uhci",
> -    .version_id = 1,
> +    .version_id = 2,
>     .minimum_version_id = 1,
>     .minimum_version_id_old = 1,
>     .pre_save = uhci_pre_save,
> @@ -392,6 +392,7 @@ static const VMStateDescription vmstate_uhci = {
>         VMSTATE_UINT8(sof_timing, UHCIState),
>         VMSTATE_UINT8(status2, UHCIState),
>         VMSTATE_TIMER(frame_timer, UHCIState),
> +        VMSTATE_INT64_V(expire_time, UHCIState, 2),
>         VMSTATE_END_OF_LIST()
>     }
>  };
> --
> 1.6.5.1.1367.gcd48
> --
> SUN OF A BEACH
>

  reply	other threads:[~2010-06-05  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  4:26 [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate TeLeMan
2010-06-05  0:46 ` TeLeMan [this message]
2010-06-30 18:44 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinAMvZo2hAgJWbQQTVisaVPsdnQsl7JSb2nACwH@mail.gmail.com \
    --to=geleman@gmail.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).