* [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate
@ 2010-06-01 4:26 TeLeMan
2010-06-05 0:46 ` [Qemu-devel] " TeLeMan
2010-06-30 18:44 ` [Qemu-devel] " Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: TeLeMan @ 2010-06-01 4:26 UTC (permalink / raw)
To: qemu-devel
The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced
expire_time of UHCIState. But expire_time is not in vmstate, the
second uhci_frame_timer will not be fired immediately after loadvm.
Signed-off-by: TeLeMan <geleman@gmail.com>
---
hw/usb-uhci.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 624d55b..d9d74c9 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -375,7 +375,7 @@ static const VMStateDescription vmstate_uhci_port = {
static const VMStateDescription vmstate_uhci = {
.name = "uhci",
- .version_id = 1,
+ .version_id = 2,
.minimum_version_id = 1,
.minimum_version_id_old = 1,
.pre_save = uhci_pre_save,
@@ -392,6 +392,7 @@ static const VMStateDescription vmstate_uhci = {
VMSTATE_UINT8(sof_timing, UHCIState),
VMSTATE_UINT8(status2, UHCIState),
VMSTATE_TIMER(frame_timer, UHCIState),
+ VMSTATE_INT64_V(expire_time, UHCIState, 2),
VMSTATE_END_OF_LIST()
}
};
--
1.6.5.1.1367.gcd48
--
SUN OF A BEACH
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate
2010-06-01 4:26 [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate TeLeMan
@ 2010-06-05 0:46 ` TeLeMan
2010-06-30 18:44 ` [Qemu-devel] " Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: TeLeMan @ 2010-06-05 0:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl
no comments?
On Tue, Jun 1, 2010 at 12:26, TeLeMan <geleman@gmail.com> wrote:
> The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced
> expire_time of UHCIState. But expire_time is not in vmstate, the
> second uhci_frame_timer will not be fired immediately after loadvm.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
> hw/usb-uhci.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 624d55b..d9d74c9 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -375,7 +375,7 @@ static const VMStateDescription vmstate_uhci_port = {
>
> static const VMStateDescription vmstate_uhci = {
> .name = "uhci",
> - .version_id = 1,
> + .version_id = 2,
> .minimum_version_id = 1,
> .minimum_version_id_old = 1,
> .pre_save = uhci_pre_save,
> @@ -392,6 +392,7 @@ static const VMStateDescription vmstate_uhci = {
> VMSTATE_UINT8(sof_timing, UHCIState),
> VMSTATE_UINT8(status2, UHCIState),
> VMSTATE_TIMER(frame_timer, UHCIState),
> + VMSTATE_INT64_V(expire_time, UHCIState, 2),
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 1.6.5.1.1367.gcd48
> --
> SUN OF A BEACH
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate
2010-06-01 4:26 [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate TeLeMan
2010-06-05 0:46 ` [Qemu-devel] " TeLeMan
@ 2010-06-30 18:44 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-06-30 18:44 UTC (permalink / raw)
To: TeLeMan; +Cc: qemu-devel
On Tue, Jun 01, 2010 at 12:26:20PM +0800, TeLeMan wrote:
> The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced
> expire_time of UHCIState. But expire_time is not in vmstate, the
> second uhci_frame_timer will not be fired immediately after loadvm.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
> hw/usb-uhci.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 624d55b..d9d74c9 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -375,7 +375,7 @@ static const VMStateDescription vmstate_uhci_port = {
>
> static const VMStateDescription vmstate_uhci = {
> .name = "uhci",
> - .version_id = 1,
> + .version_id = 2,
> .minimum_version_id = 1,
> .minimum_version_id_old = 1,
> .pre_save = uhci_pre_save,
> @@ -392,6 +392,7 @@ static const VMStateDescription vmstate_uhci = {
> VMSTATE_UINT8(sof_timing, UHCIState),
> VMSTATE_UINT8(status2, UHCIState),
> VMSTATE_TIMER(frame_timer, UHCIState),
> + VMSTATE_INT64_V(expire_time, UHCIState, 2),
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 1.6.5.1.1367.gcd48
> --
> SUN OF A BEACH
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-30 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-01 4:26 [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate TeLeMan
2010-06-05 0:46 ` [Qemu-devel] " TeLeMan
2010-06-30 18:44 ` [Qemu-devel] " Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).