From: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: aliguori@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c
Date: Fri, 14 May 2010 17:32:25 -0300 [thread overview]
Message-ID: <AANLkTinBi8vCF3I3cLdcC8-xXvYSbP3y1rgwrf812fnk@mail.gmail.com> (raw)
In-Reply-To: <4BED825E.7050505@siemens.com>
On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>
>> In both cases the info_str string is written inside
>> net_socket_fd_init_(stream|dgram), and after that, it is
>> overwritten on a subsequent snprintf() in net_socket_accept().
>>
>
> There is non-zero time window between registration and acceptance. And
> you have the path taken for fd sockets.
>
It is non-zero, yes, but what is the point of writing to info_str with
an fd number for less them 5ms, when that value will be overwritten
anyway?
I'm an student, just trying to understand what is going on :-D
Regards,
Miguel
next prev parent reply other threads:[~2010-05-14 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 16:40 [Qemu-devel] [PATCH] net: Remove dead code from net/socket.c Miguel Di Ciurcio Filho
2010-05-14 17:03 ` [Qemu-devel] " Jan Kiszka
2010-05-14 20:32 ` Miguel Di Ciurcio Filho [this message]
2010-05-17 7:23 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinBi8vCF3I3cLdcC8-xXvYSbP3y1rgwrf812fnk@mail.gmail.com \
--to=miguel.filho@gmail.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).