From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37455 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pav4M-0000Oj-0y for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:00:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pav4F-0002PV-2V for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:00:12 -0500 Received: from mail-ey0-f173.google.com ([209.85.215.173]:47970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pav4E-0002PD-Qu for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:00:10 -0500 Received: by eyg7 with SMTP id 7so4648559eyg.4 for ; Thu, 06 Jan 2011 11:00:09 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1294340003-684-1-git-send-email-aurelien@aurel32.net> References: <1294340003-684-1-git-send-email-aurelien@aurel32.net> Date: Thu, 6 Jan 2011 19:00:09 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 6 January 2011 18:53, Aurelien Jarno wrote: > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > both (different) implementations are wrong. They try to avoid a 64-bit > add for the rounding, which is not trivial if you want to support both > SMMLA and SMMLS with the same code. > > The code below uses the same implementation for both modes, using the > code from the ARM manual. It also fixes the thumb decoding that was a > mix between normal and thumb mode. > > This fixes the issues reported in > https://bugs.launchpad.net/qemu/+bug/629298 > > v2: improve comments with the help from Peter Maydell. > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno Confirmed that this is just comment changes since v1, and it still passes the tests. So: Reviewed-by: Peter Maydell -- PMM