From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-devel] Re: [PATCH v2 3/4] qed: Report error for unsupported features
Date: Thu, 10 Feb 2011 12:07:13 +0000 [thread overview]
Message-ID: <AANLkTinFEtpoQFNjOTJh=yn-yebswNx6iGLrpgoM_u78@mail.gmail.com> (raw)
In-Reply-To: <1297336703-15632-4-git-send-email-kwolf@redhat.com>
On Thu, Feb 10, 2011 at 11:18 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Instead of just returning -ENOTSUP, generate a more detailed error.
>
> Unfortunately we don't have a helpful text for features that we don't know yet,
> so just print the feature mask. It might be useful at least if someone asks for
> help.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qed.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
Thanks!
Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-02-10 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 11:18 [Qemu-devel] [PATCH 0.14/master v2 0/4] Error messages for unsupoorted image format features Kevin Wolf
2011-02-10 11:18 ` [Qemu-devel] [PATCH v2 1/4] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE Kevin Wolf
2011-02-10 11:18 ` [Qemu-devel] [PATCH v2 2/4] qcow2: Report error for version > 2 Kevin Wolf
2011-02-10 11:18 ` [Qemu-devel] [PATCH v2 3/4] qed: Report error for unsupported features Kevin Wolf
2011-02-10 12:07 ` Stefan Hajnoczi [this message]
2011-02-10 11:18 ` [Qemu-devel] [PATCH v2 4/4] qemu-img: Improve error messages for failed bdrv_open Kevin Wolf
2011-02-10 12:14 ` [Qemu-devel] Re: [PATCH 0.14/master v2 0/4] Error messages for unsupoorted image format features Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinFEtpoQFNjOTJh=yn-yebswNx6iGLrpgoM_u78@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).