From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56661 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PP9sY-0007KK-CD
	for qemu-devel@nongnu.org; Sun, 05 Dec 2010 03:23:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PP9sW-0008Sv-P8
	for qemu-devel@nongnu.org; Sun, 05 Dec 2010 03:23:30 -0500
Received: from mail-pv0-f173.google.com ([74.125.83.173]:62894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PP9sW-0008SY-E0
	for qemu-devel@nongnu.org; Sun, 05 Dec 2010 03:23:28 -0500
Received: by pvh11 with SMTP id 11so2041040pvh.4
	for <qemu-devel@nongnu.org>; Sun, 05 Dec 2010 00:23:27 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1291232678-31556-1-git-send-email-peter.maydell@linaro.org>
References: <1291232678-31556-1-git-send-email-peter.maydell@linaro.org>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 5 Dec 2010 08:23:07 +0000
Message-ID: <AANLkTinFEyUtzzk++dJQqCmx+aBSNw=LUV7SFyBBDj+7@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Remove unused spin_trylock() function
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Thanks, applied.

On Wed, Dec 1, 2010 at 7:44 PM, Peter Maydell <peter.maydell@linaro.org> wr=
ote:
> Remove the spin_trylock() function, as it is not used anywhere,
> and is not even implemented if CONFIG_USE_NPTL is defined.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> =C2=A0qemu-lock.h | =C2=A0 10 ----------
> =C2=A01 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/qemu-lock.h b/qemu-lock.h
> index 9a3e6ac..65ca084 100644
> --- a/qemu-lock.h
> +++ b/qemu-lock.h
> @@ -224,11 +224,6 @@ static inline void spin_unlock(spinlock_t *lock)
> =C2=A0{
> =C2=A0 =C2=A0 resetlock(lock);
> =C2=A0}
> -
> -static inline int spin_trylock(spinlock_t *lock)
> -{
> - =C2=A0 =C2=A0return !testandset(lock);
> -}
> =C2=A0#else
> =C2=A0static inline void spin_lock(spinlock_t *lock)
> =C2=A0{
> @@ -237,11 +232,6 @@ static inline void spin_lock(spinlock_t *lock)
> =C2=A0static inline void spin_unlock(spinlock_t *lock)
> =C2=A0{
> =C2=A0}
> -
> -static inline int spin_trylock(spinlock_t *lock)
> -{
> - =C2=A0 =C2=A0return 1;
> -}
> =C2=A0#endif
>
> =C2=A0#endif
> --
> 1.7.1
>
>
>