[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

[Miguel Di Ciurcio Filho <miguel.filho@gmail.com>]

On Fri, Jul 16, 2010 at 3:34 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
>
>> - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on
>
> Let the sending peer report (offset field or callback) where to find the
> payload in a frame.
>

Looking further, do you mean what net.c:vc_sendv_compat() does?

> That channel - or a separate one - could also be used to detect if a
> peer supports dumping at all (vhost...). Then no peer code need to be
> extended with dump management code, all could be moved into net.c
>

What do you mean by channel? (sorry, I'm kinda new around here :-)
I don't see how to put everything into net.c. Options parsing/setting
go inside each backend that adds a NetClientDump instance (just a few
lines as seen in my patch on net/tap.c as example), and when packets
come through net.c (qemu_deliver_packet_*()) we get them, right?

Regards,

Miguel