From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54347 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ORnSn-00044c-Cq
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 10:31:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1ORnSm-0008AH-6R
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 10:31:33 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:58899)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@gmail.com>) id 1ORnSm-0008A9-2X
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 10:31:32 -0400
Received: by vws10 with SMTP id 10so3545806vws.4
	for <qemu-devel@nongnu.org>; Thu, 24 Jun 2010 07:31:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <22a96312232a0458fc04268b79d17828c824df42.1276588830.git.amit.shah@redhat.com>
References: <22a96312232a0458fc04268b79d17828c824df42.1276588830.git.amit.shah@redhat.com>
Date: Thu, 24 Jun 2010 15:31:29 +0100
Message-ID: <AANLkTinLglANVQ19pDVK8lIa3gMEuxBtw1quZ6u3F9ey@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] net: Fix VM start with '-net none'
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, "\\\"Michael S. Tsirkin\\\"" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On Tue, Jun 15, 2010 at 9:00 AM, Amit Shah <amit.shah@redhat.com> wrote:
> Commit 50e32ea8f31035877decc10f1075aa0e619e09cb changed the behaviour
> for the return type of net_client_init() when a nic type with no init
> method was specified. 'none' is one such nic type. Instead of returning
> 0, which gets interpreted as an index into the nd_table[] array, we
> switched to returning -1, which signifies an error as well.
>
> That broke VM start with '-net none'. Testing was only done with the
> monitor command 'pci_add', which doesn't fail.

I stumbled across the broken -net none in qemu.git and qemu-kvm.git.
It does a silent exit(1) on startup.

It would be nice to merge this patch.

Stefan