From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Opokh-0000I7-W9 for qemu-devel@nongnu.org; Sun, 29 Aug 2010 16:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Opokg-0006jY-Uk for qemu-devel@nongnu.org; Sun, 29 Aug 2010 16:45:19 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:53764) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Opokg-0006jQ-Rp for qemu-devel@nongnu.org; Sun, 29 Aug 2010 16:45:18 -0400 Received: by qwh5 with SMTP id 5so4559553qwh.4 for ; Sun, 29 Aug 2010 13:45:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20100829095558.GA8162@8bytes.org> References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> <20100829095558.GA8162@8bytes.org> From: Blue Swirl Date: Sun, 29 Aug 2010 20:44:40 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patchset v4 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joerg Roedel Cc: kvm@vger.kernel.org, mst@redhat.com, qemu-devel@nongnu.org, yamahata@valinux.co.jp, avi@redhat.com, Eduard - Gabriel Munteanu , paul@codesourcery.com On Sun, Aug 29, 2010 at 9:55 AM, Joerg Roedel wrote: > On Sat, Aug 28, 2010 at 04:00:31PM +0000, Blue Swirl wrote: >> On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu > >> > Please have a look and merge if you like it. >> >> The endianess bug still exists. I had also other comments to 2. > > I am very happy with this patch set. Besides your comments, is there > anything else that prevents merging of this patch set? Paul, what is > your opinion in this? I also think it's nice piece of work. It would be good to fix the CODING_STYLE (missing braces) problem in 2 before merging. The endianess problem is not so much of a problem, my mistake.