From: Aaron Mason <aaron.mason@thats-too-much.info>
To: Kevin Wolf <kwolf@redhat.com>, andrzej zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
Date: Fri, 6 Aug 2010 21:40:58 +1000 [thread overview]
Message-ID: <AANLkTinNaK1kfZTsvkqPnZ8TB-KUcex_VLcAp3Emh8iP@mail.gmail.com> (raw)
In-Reply-To: <3621879199971178442@unknownmsgid>
Let's try that again.
I'd paste it but GMail likes to break patches to honour the 73 char
limit. I'll install Git on my home PC and try git send-email from
there (my work PC is behind a restrictive firewall so email via Gmail
is out).
Thanks for finding more that I missed, I'll fix them on Monday next
time I'm in the office.
On Thu, Aug 5, 2010 at 7:07 AM, Aaron Mason
<aaron.mason@thats-too-much.info> wrote:
> there
>
> sent from my Telstra NEXTG™ handset
>
> -----Original Message-----
> From: Kevin Wolf <kwolf@redhat.com>
> Sent: Wednesday, 4 August 2010 10:29 PM
> To: andrzej zaborowski <balrogg@gmail.com>
> Cc: Aaron Mason <aaron.mason@thats-too-much.info>; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
>
> Am 04.08.2010 14:27, schrieb andrzej zaborowski:
>> Hi,
>>
>> On 4 August 2010 12:30, Kevin Wolf <kwolf@redhat.com> wrote:
>>> Am 04.08.2010 01:46, schrieb Aaron Mason:
>>>> + const char *real_filename, *temp_str, *adapterType = "ide";
>>
>> Sorry to complain about style, but note that uppercase characters are
>> not used in variable names in Qemu (that I see).
>
> Whoops, missed that one when complaining about the other style problems.
> Yes, this should be adapter_type.
>
> Kevin
>
next parent reply other threads:[~2010-08-06 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3621879199971178442@unknownmsgid>
2010-08-06 11:40 ` Aaron Mason [this message]
2010-08-04 21:07 [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type Aaron Mason
-- strict thread matches above, loose matches on Subject: below --
2010-08-03 23:46 Aaron Mason
2010-08-04 7:16 ` Natalia Portillo
2010-08-04 10:30 ` Kevin Wolf
2010-08-04 12:27 ` andrzej zaborowski
2010-08-04 12:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinNaK1kfZTsvkqPnZ8TB-KUcex_VLcAp3Emh8iP@mail.gmail.com \
--to=aaron.mason@thats-too-much.info \
--cc=balrogg@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).