From: Jun Koi <junkoi2004@gmail.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] regs_to_env() ?
Date: Fri, 23 Jul 2010 10:51:20 +0900 [thread overview]
Message-ID: <AANLkTinQecm6dLjK6=74xxOkjGYeYAG-NbsS5oUL9f+m@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=0shFU8GQPmRsZQG8=7Anes=e=byz1+ap60mvN@mail.gmail.com>
On Fri, Jul 23, 2010 at 10:43 AM, Jun Koi <junkoi2004@gmail.com> wrote:
> On Fri, Jul 23, 2010 at 7:08 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Thu, Jul 22, 2010 at 2:06 AM, Jun Koi <junkoi2004@gmail.com> wrote:
>>> Hi,
>>>
>>> Function regs_to_env() in target-i386/exec.h has a code like below:
>>>
>>> ...
>>> #ifdef reg_EAX
>>> env->regs[R_EAX] = EAX
>>> #endif
>>> ...
>>>
>>> However, elsewhere we have EAX defined as:
>>>
>>> #define EAX (env->regs[R_EAX])
>>>
>>> This means effectively, we have code like:
>>>
>>> env->regs[R_EAX] = env->regs[R_EAX];
>>>
>>> What is the meaning of this code? That looks pointless to me, but I
>>> guess I must be wrong here...
>>
>> Yes, those lines don't exist anymore, they were used before TCG. IIRC
>> EAX was defined to AREG1 etc.
>>
>
> hey, that sounds funny.
>
> will you take a patch removing both regs_to_env() and env_to_regs() ?
oops that was removed in latest code already. (i looked at 0.12.4 code)
thanks,
J
prev parent reply other threads:[~2010-07-23 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 2:06 [Qemu-devel] regs_to_env() ? Jun Koi
2010-07-22 22:08 ` Blue Swirl
2010-07-23 1:43 ` Jun Koi
2010-07-23 1:51 ` Jun Koi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinQecm6dLjK6=74xxOkjGYeYAG-NbsS5oUL9f+m@mail.gmail.com' \
--to=junkoi2004@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).