From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46942 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwaTX-0006Hm-O4
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:27:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PwaTW-0005DZ-Mi
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:27:51 -0500
Received: from mail-gw0-f46.google.com ([74.125.83.46]:54851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PwaTW-0005DM-KR
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:27:50 -0500
Received: by gwj20 with SMTP id 20so2542034gwj.33
	for <qemu-devel@nongnu.org>; Mon, 07 Mar 2011 05:27:50 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1299460984-15849-14-git-send-email-aliguori@us.ibm.com>
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>
	<1299460984-15849-14-git-send-email-aliguori@us.ibm.com>
Date: Mon, 7 Mar 2011 13:27:49 +0000
Message-ID: <AANLkTinT3NFZXYthbVyPupEqM9SMYFymnzA672zUKYs4@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP
	command marshaling
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Adam Litke <aglitke@linux.vnet.ibm.com>

On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> +def print_definition(name, required, optional, retval):

This function is pretty long.  Is there a logical way to split it up
into several smaller meaningful functions?

Stefan