From: Blue Swirl <blauwirbel@gmail.com>
To: Michal Novotny <minovotn@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix vhost_net compilation errors for i386-softmmu target
Date: Mon, 20 Sep 2010 18:03:26 +0000 [thread overview]
Message-ID: <AANLkTinUvvOt9HjKC75Lj0tSCNSe6WfTQ1eWsH+OcAbR@mail.gmail.com> (raw)
In-Reply-To: <4C972B3A.7000800@redhat.com>
On Mon, Sep 20, 2010 at 9:36 AM, Michal Novotny <minovotn@redhat.com> wrote:
> Hi,
> there were compilation errors when I was trying to compile i386-softmmu
> target on i386
> host (running on Fedora-13 with development version of qemu downloaded from
> git).
>
> There were errors of comparison of unsigned expression was always true which
> made it
> unable to compile. This simple fix fixes the issue.
>
> ...
> cc1: warnings being treated as errors
> .../hw/vhost_net.c: In function ‘vhost_net_start’:
> .../vhost_net.c:154: error: comparison of unsigned expression >= 0 is always
> true
> make[1]: *** [vhost_net.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
I don't think the patch is correct. It looks like zero is a valid
value for file.index, changing the check means that the ioctl is not
performed for case file.index == 0.
The preincrements and predecrements seem suspicious.
prev parent reply other threads:[~2010-09-20 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 9:36 [Qemu-devel] [PATCH] Fix vhost_net compilation errors for i386-softmmu target Michal Novotny
2010-09-20 17:53 ` [Qemu-devel] " Michael S. Tsirkin
2010-09-21 7:03 ` Michal Novotny
2010-09-20 18:03 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinUvvOt9HjKC75Lj0tSCNSe6WfTQ1eWsH+OcAbR@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=minovotn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).