[Qemu-devel] [PATCH] configure: Remove unneeded defines from checks

[Qemu-devel] [PATCH] configure: Remove unneeded defines from checks

[Stefan Weil]

_GNU_SOURCE is already defined in QEMU_CFLAGS which
is passed to gcc in shell function compile_prog.

Removing the definition from several checks avoids compiler warnings
(which are now written to config.log).

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 configure |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 9e65de0..e67d076 100755
--- a/configure
+++ b/configure
@@ -1888,7 +1888,6 @@ fi
 utimens=no
 cat > $TMPC << EOF
 #define _ATFILE_SOURCE
-#define _GNU_SOURCE
 #include <stddef.h>
 #include <fcntl.h>
 
@@ -1906,7 +1905,6 @@ fi
 # check if pipe2 is there
 pipe2=no
 cat > $TMPC << EOF
-#define _GNU_SOURCE
 #include <unistd.h>
 #include <fcntl.h>
 
@@ -1924,7 +1922,6 @@ fi
 # check if accept4 is there
 accept4=no
 cat > $TMPC << EOF
-#define _GNU_SOURCE
 #include <sys/socket.h>
 #include <stddef.h>
 
@@ -1941,7 +1938,6 @@ fi
 # check if tee/splice is there. vmsplice was added same time.
 splice=no
 cat > $TMPC << EOF
-#define _GNU_SOURCE
 #include <unistd.h>
 #include <fcntl.h>
 #include <limits.h>
-- 
1.7.1

Re: [Qemu-devel] [PATCH] configure: Remove unneeded defines from checks

[Blue Swirl]

Thanks, applied.

On Wed, Oct 6, 2010 at 7:09 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> _GNU_SOURCE is already defined in QEMU_CFLAGS which
> is passed to gcc in shell function compile_prog.
>
> Removing the definition from several checks avoids compiler warnings
> (which are now written to config.log).
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  configure |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 9e65de0..e67d076 100755
> --- a/configure
> +++ b/configure
> @@ -1888,7 +1888,6 @@ fi
>  utimens=no
>  cat > $TMPC << EOF
>  #define _ATFILE_SOURCE
> -#define _GNU_SOURCE
>  #include <stddef.h>
>  #include <fcntl.h>
>
> @@ -1906,7 +1905,6 @@ fi
>  # check if pipe2 is there
>  pipe2=no
>  cat > $TMPC << EOF
> -#define _GNU_SOURCE
>  #include <unistd.h>
>  #include <fcntl.h>
>
> @@ -1924,7 +1922,6 @@ fi
>  # check if accept4 is there
>  accept4=no
>  cat > $TMPC << EOF
> -#define _GNU_SOURCE
>  #include <sys/socket.h>
>  #include <stddef.h>
>
> @@ -1941,7 +1938,6 @@ fi
>  # check if tee/splice is there. vmsplice was added same time.
>  splice=no
>  cat > $TMPC << EOF
> -#define _GNU_SOURCE
>  #include <unistd.h>
>  #include <fcntl.h>
>  #include <limits.h>
> --
> 1.7.1
>
>
>