From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48105 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4Vx9-0007GA-NV
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:42:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P4Vx8-0005kO-8k
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:42:55 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:41032)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P4Vx8-0005kJ-59
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:42:54 -0400
Received: by qwh5 with SMTP id 5so148251qwh.4
	for <qemu-devel@nongnu.org>; Sat, 09 Oct 2010 02:42:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1286392157-30903-1-git-send-email-weil@mail.berlios.de>
References: <1286392157-30903-1-git-send-email-weil@mail.berlios.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 9 Oct 2010 09:42:33 +0000
Message-ID: <AANLkTin_7_RLhGqhVn+6ZErVt-qvCV_US369f6h8iaH6@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Remove unneeded defines from
	checks
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Thanks, applied.

On Wed, Oct 6, 2010 at 7:09 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> _GNU_SOURCE is already defined in QEMU_CFLAGS which
> is passed to gcc in shell function compile_prog.
>
> Removing the definition from several checks avoids compiler warnings
> (which are now written to config.log).
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> =C2=A0configure | =C2=A0 =C2=A04 ----
> =C2=A01 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 9e65de0..e67d076 100755
> --- a/configure
> +++ b/configure
> @@ -1888,7 +1888,6 @@ fi
> =C2=A0utimens=3Dno
> =C2=A0cat > $TMPC << EOF
> =C2=A0#define _ATFILE_SOURCE
> -#define _GNU_SOURCE
> =C2=A0#include <stddef.h>
> =C2=A0#include <fcntl.h>
>
> @@ -1906,7 +1905,6 @@ fi
> =C2=A0# check if pipe2 is there
> =C2=A0pipe2=3Dno
> =C2=A0cat > $TMPC << EOF
> -#define _GNU_SOURCE
> =C2=A0#include <unistd.h>
> =C2=A0#include <fcntl.h>
>
> @@ -1924,7 +1922,6 @@ fi
> =C2=A0# check if accept4 is there
> =C2=A0accept4=3Dno
> =C2=A0cat > $TMPC << EOF
> -#define _GNU_SOURCE
> =C2=A0#include <sys/socket.h>
> =C2=A0#include <stddef.h>
>
> @@ -1941,7 +1938,6 @@ fi
> =C2=A0# check if tee/splice is there. vmsplice was added same time.
> =C2=A0splice=3Dno
> =C2=A0cat > $TMPC << EOF
> -#define _GNU_SOURCE
> =C2=A0#include <unistd.h>
> =C2=A0#include <fcntl.h>
> =C2=A0#include <limits.h>
> --
> 1.7.1
>
>
>