From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50570 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ok0sw-0004Yh-9J for qemu-devel@nongnu.org; Fri, 13 Aug 2010 16:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ok0sv-0007TK-4w for qemu-devel@nongnu.org; Fri, 13 Aug 2010 16:29:50 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:49066) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ok0sv-0007TG-2o for qemu-devel@nongnu.org; Fri, 13 Aug 2010 16:29:49 -0400 Received: by qwh5 with SMTP id 5so3413255qwh.4 for ; Fri, 13 Aug 2010 13:29:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1280771901-9758-1-git-send-email-atar4qemu@gmail.com> From: Artyom Tarasenko Date: Fri, 13 Aug 2010 22:29:28 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl , Anthony Liguori Cc: qemu-devel@nongnu.org 2010/8/6 Artyom Tarasenko : > 2010/8/2 Artyom Tarasenko : >> Btw, it would be nice to get this patch applied for 0.13: it's a pure >> fix, and it allows running the OBP v2.10 for LX and some older OBP >> versions for SS-20 too. > > ping? Objections? > No feedback? Are 0.13 patches only accepted with "0.13" in the subject line? Are sparc patches generally not welcome for the stable release? >> 2010/8/2 Blue Swirl : >>> Thanks, applied. Please remember to use Signed-off-by tag. >> >> Grrr. Git 1.6.2.5 seems to ignore the option signoff =3D true in the >> config file. I'll update my git right now. >> >>> >>> >>> On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko >>> wrote: >>>> The timer #0 is the system timer, so the timer #num_cpu is the >>>> timer of the last CPU, and it must be initialized in slavio_timer_rese= t. >>>> >>>> Don't mark non-existing timers as running. >>>> --- >>>> =A0hw/slavio_timer.c | =A0 =A04 ++-- >>>> =A01 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c >>>> index d787553..c125de4 100644 >>>> --- a/hw/slavio_timer.c >>>> +++ b/hw/slavio_timer.c >>>> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d) >>>> =A0 =A0 =A0 =A0 curr_timer->limit =3D 0; >>>> =A0 =A0 =A0 =A0 curr_timer->count =3D 0; >>>> =A0 =A0 =A0 =A0 curr_timer->reached =3D 0; >>>> - =A0 =A0 =A0 =A0if (i < s->num_cpus) { >>>> + =A0 =A0 =A0 =A0if (i <=3D s->num_cpus) { >>>> =A0 =A0 =A0 =A0 =A0 =A0 ptimer_set_limit(curr_timer->timer, >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0LIMIT_TO_PE= RIODS(TIMER_MAX_COUNT32), 1); >>>> =A0 =A0 =A0 =A0 =A0 =A0 ptimer_run(curr_timer->timer, 0); >>>> + =A0 =A0 =A0 =A0 =A0 =A0curr_timer->running =3D 1; >>>> =A0 =A0 =A0 =A0 } >>>> - =A0 =A0 =A0 =A0curr_timer->running =3D 1; >>>> =A0 =A0 } >>>> =A0 =A0 s->cputimer_mode =3D 0; >>>> =A0} >>>> -- >>>> 1.6.2.5 >>>> >>>> >>> > > > -- > Regards, > Artyom Tarasenko > > solaris/sparc under qemu blog: http://tyom.blogspot.com/ > --=20 Regards, Artyom Tarasenko solaris/sparc under qemu blog: http://tyom.blogspot.com/