From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33769 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PvrUv-0000wU-Tx
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 08:26:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PvrUq-0002jV-Tr
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 08:26:17 -0500
Received: from mail-vx0-f173.google.com ([209.85.220.173]:47893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PvrUq-0002jM-RS
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 08:26:12 -0500
Received: by vxb41 with SMTP id 41so2986239vxb.4
	for <qemu-devel@nongnu.org>; Sat, 05 Mar 2011 05:26:12 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.02.1103051342010.22602@bbs.intern>
References: <alpine.LFD.2.02.1103051342010.22602@bbs.intern>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 5 Mar 2011 15:25:52 +0200
Message-ID: <AANLkTinbtmYf=H5kap_RoQHc=-y8AprY8ttMgVhNLLv7@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD
	netware drivers
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: qemu-devel@nongnu.org

Thanks, applied.

There were still some white space problem with the patch, the
unchanged lines had shifted by one space.

On Sat, Mar 5, 2011 at 2:44 PM, Gerhard Wiesinger <lists@wiesinger.com> wro=
te:
> bugfix under DOS for AMD netware driver:
> AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found
>
> bugfix works well under DOS with:
> 1.) AMD NDIS driver v2.0.1
> 2.) AMD PCNTNW Ethernet MLID v3.10 (960115)
> 3.) Knoppix 6.2
>
> Signed-off-by: Gerhard Wiesinger <lists@wiesinger.com>
> ---
> =C2=A0hw/pcnet.c | =C2=A0 16 ++++++++++++++++
> =C2=A01 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index db52dc5..6dfdcc4 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1562,8 +1562,24 @@ void pcnet_h_reset(void *opaque)
>
> =C2=A0 =C2=A0 /* Initialize the PROM */
>
> + =C2=A0 =C2=A0/*
> + =C2=A0 =C2=A0 =C2=A0Datasheet: http://pdfdata.datasheetsite.com/web/245=
28/AM79C970A.pdf
> + =C2=A0 =C2=A0 =C2=A0page 95
> + =C2=A0 =C2=A0*/
> =C2=A0 =C2=A0 memcpy(s->prom, s->conf.macaddr.a, 6);
> + =C2=A0 =C2=A0/* Reserved Location: must be 00h */
> + =C2=A0 =C2=A0s->prom[6] =3D s->prom[7] =3D 0x00;
> + =C2=A0 =C2=A0/* Reserved Location: must be 00h */
> + =C2=A0 =C2=A0s->prom[8] =3D 0x00;
> + =C2=A0 =C2=A0/* Hardware ID: must be 11h if compatibility to AMD driver=
s is desired
> */
> + =C2=A0 =C2=A0s->prom[9] =3D 0x11;
> + =C2=A0 =C2=A0/* User programmable space, init with 0 */
> + =C2=A0 =C2=A0s->prom[10] =3D s->prom[11] =3D 0x00;
> + =C2=A0 =C2=A0/* LSByte of two-byte checksum, which is the sum of bytes =
00h-0Bh
> + =C2=A0 =C2=A0 =C2=A0 and bytes 0Eh and 0Fh, must therefore be initializ=
ed with 0! */
> =C2=A0 =C2=A0 s->prom[12] =3D s->prom[13] =3D 0x00;
> + =C2=A0 =C2=A0/* Must be ASCII W (57h) if compatibility to AMD
> + =C2=A0 =C2=A0 =C2=A0 driver software is desired */
> =C2=A0 =C2=A0 s->prom[14] =3D s->prom[15] =3D 0x57;
>
> =C2=A0 =C2=A0 for (i =3D 0,checksum =3D 0; i < 16; i++)
> --
> 1.7.3.4
>
>
>