From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>,
Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change
Date: Fri, 1 Apr 2011 15:09:28 +0100 [thread overview]
Message-ID: <AANLkTineJ5FiuZJWFVSt56D9tUFLpp3LYhe9AazSKXZx@mail.gmail.com> (raw)
In-Reply-To: <4D945206.6090204@redhat.com>
On Thu, Mar 31, 2011 at 11:05 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> The other thing is that I'm not sure if everything in raw-posix is
> prepared to deal with a -1 fd. At the very least, I think we'll get
> -EBADF errors instead of the expected -ENOMEDIUM.
Not all of block.c checks for !bdrv_is_inserted() so you are right, I
missed cases where we should return -ENOMEDIUM.
We have a similar scenario with floppy disks where fd_open() can
return leaving s->fd == -1. I would like to unify these floppy and
CD-ROM open cases.
Stefan
next prev parent reply other threads:[~2011-04-01 14:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 19:04 [Qemu-devel] [PATCH v2 0/3] block: Correct size across CD-ROM media change Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 1/3] trace: Trace bdrv_set_locked() Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 2/3] block: Do not cache device size for removable media Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change Stefan Hajnoczi
2011-03-31 10:05 ` [Qemu-devel] " Kevin Wolf
2011-04-01 14:09 ` Stefan Hajnoczi [this message]
2011-04-03 11:57 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-03 13:12 ` Blue Swirl
2011-04-03 18:06 ` Stefan Hajnoczi
2011-04-04 10:47 ` [libvirt] " Daniel P. Berrange
2011-04-04 12:58 ` Stefan Hajnoczi
2011-04-04 13:02 ` Anthony Liguori
2011-04-04 13:16 ` Daniel P. Berrange
2011-04-04 14:19 ` Anthony Liguori
2011-04-04 14:26 ` Daniel P. Berrange
2011-04-04 14:43 ` Anthony Liguori
2011-04-04 16:38 ` Blue Swirl
2011-04-04 13:22 ` Avi Kivity
2011-04-04 13:38 ` Anthony Liguori
2011-04-04 13:49 ` Avi Kivity
2011-04-04 15:09 ` Stefan Hajnoczi
2011-04-04 15:11 ` Avi Kivity
2011-04-05 6:41 ` Amit Shah
2011-04-05 7:48 ` Avi Kivity
2011-04-05 8:09 ` Amit Shah
2011-04-05 9:00 ` Avi Kivity
2011-04-05 9:12 ` Amit Shah
2011-04-05 9:17 ` Avi Kivity
2011-04-05 9:26 ` Amit Shah
2011-04-06 8:07 ` Amit Shah
2011-04-05 8:40 ` Stefan Hajnoczi
2011-04-05 8:58 ` Amit Shah
2011-04-04 17:54 ` David Ahern
2011-04-05 5:33 ` Stefan Hajnoczi
2011-04-05 5:42 ` David Ahern
2011-04-05 12:41 ` Stefan Hajnoczi
2011-03-30 8:33 ` [Qemu-devel] [PATCH v2 0/3] block: Correct size across CD-ROM " Markus Armbruster
2011-03-30 10:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTineJ5FiuZJWFVSt56D9tUFLpp3LYhe9AazSKXZx@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ryanh@us.ibm.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).