From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37282 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OeqnP-00023U-Pb
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:42:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <miguel.filho@gmail.com>) id 1OeqnO-0004nn-Pz
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:42:47 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:44445)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <miguel.filho@gmail.com>) id 1OeqnO-0004nV-KU
	for qemu-devel@nongnu.org; Fri, 30 Jul 2010 10:42:46 -0400
Received: by wwb39 with SMTP id 39so1528582wwb.10
	for <qemu-devel@nongnu.org>; Fri, 30 Jul 2010 07:42:44 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100730103906.551adacd@redhat.com>
References: <1280345424-12918-1-git-send-email-miguel.filho@gmail.com>
	<1280345424-12918-4-git-send-email-miguel.filho@gmail.com>
	<20100730103906.551adacd@redhat.com>
Date: Fri, 30 Jul 2010 11:42:44 -0300
Message-ID: <AANLkTineY8=d+r6GjdBosZF_QF68+aGftb9xKwFOe2r3@mail.gmail.com>
From: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting
	and generate a default name
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino
<lcapitulino@redhat.com> wrote:
>>
>> TODO: I have no clue on how to create a timestamp string when using Wind=
ows.
>
> So, what happens on windows?
>

I've found some code in bdrv_snapshot_dump() that formats a timestamp
when using Windows. I will use it as a basis.

> Also, please, avoid making changes which are unrelated to the patch, like=
:
>
>> =A0 the_end:
>> - =A0 =A0if (saved_vm_running)
>> + =A0 =A0if (saved_vm_running) {
>> =A0 =A0 =A0 =A0 =A0vm_start();
>> + =A0 =A0}
>> =A0}
>>

Ack. Coding style cleanups must have a separate patch :-D

Regards,

Miguel