From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55984 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOv8R-0004AY-B0
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <corentin.chary@gmail.com>) id 1OOv8P-00009B-Kd
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:06:38 -0400
Received: from fg-out-1718.google.com ([72.14.220.158]:17760)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <corentin.chary@gmail.com>) id 1OOv8P-000092-Dv
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:06:37 -0400
Received: by fg-out-1718.google.com with SMTP id 22so1281094fge.10
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 09:06:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4C18F348.9000909@linux.vnet.ibm.com>
References: <20100616115404.10988.62371.stgit@localhost.localdomain>
	<20100616115656.10988.96529.stgit@localhost.localdomain>
	<4C18C4C8.8090901@redhat.com>
	<20100616142236.GA20052@shareable.org>
	<4C18DFD7.1090102@redhat.com> <4C18E1E8.3030606@linux.vnet.ibm.com>
	<4C18E52B.9010600@redhat.com> <4C18EBC4.4040603@linux.vnet.ibm.com>
	<AANLkTinfoYdKrOBqO20WU-IUDHVPsXia0K_V6zAc4Ndb@mail.gmail.com>
	<4C18F348.9000909@linux.vnet.ibm.com>
Date: Wed, 16 Jun 2010 18:06:35 +0200
Message-ID: <AANLkTinfO2Ezw7TPHGg8ICgOjFKx-CyAfhzxy6LGZ7-8@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading
	framework: threadlets
From: Corentin Chary <corentin.chary@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>, Qemu-development List <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

On Wed, Jun 16, 2010 at 5:52 PM, Anthony Liguori
<aliguori@linux.vnet.ibm.com> wrote:
> On 06/16/2010 10:47 AM, Corentin Chary wrote:
>>
>> I would need something like flush_threadlet_queue for the vnc server.
>> I need it in
>> vnc_disconnect(), vnc_dpy_resize() and vnc_dpy_cpy() so wait (and/or
>> abort) current
>> encoding jobs.
>>
>
> I'm not sure threadlets are the right thing for the VNC server. =A0The VN=
C
> server wants one dedicated thread. =A0Threadlets are a thread pool. =A0Yo=
u could
> potentially use one thread per client but I doubt it would be worth it.
>
> At any rate, flushing the full queue is overkill. =A0You want to wait for=
 your
> specific thread to terminate and you want to block execution until that
> happens. =A0IOW, you want to join the thread.
>

Oh right, I should have read the changelog more carefully, it's a
global queue now ...

Thanks,
--=20
Corentin Chary
http://xf.iksaif.net