From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add qcow2 documentation
Date: Tue, 8 Mar 2011 13:48:15 +0000 [thread overview]
Message-ID: <AANLkTinjMFoBXtxLaQobVRmq7EkOpiM_Dt0R8NQwcWmf@mail.gmail.com> (raw)
In-Reply-To: <4D762FCE.7060808@redhat.com>
On Tue, Mar 8, 2011 at 1:31 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 08.03.2011 14:13, schrieb Stefan Hajnoczi:
>> On Tue, Mar 8, 2011 at 11:47 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>>> + 20 - 23: cluster_bits
>>> + Number of bits that are used for addressing an offset
>>> + within a cluster (1 << cluster_bits is the cluster size)
>>> +
>>> + 24 - 31: size
>>> + Virtual disk size in bytes
>>
>> Any constraints on these two fields that should be mentioned?
>
> For the size not that I'm aware of.
>
> For cluster_bits qemu restricts it to 512 <= cluster_size <= 2 MB. I
> think we should add 512 as a lower limit, anything smaller doesn't make
> sense and steals us bits that we want to use for flags.
>
> The 2 MB are more of an implementation limitation. Would you mention it
> here? The format shouldn't have any problem with larger sizes.
It could be mentioned as an explicit implementation limit so that a
third party implementing qcow2 support from scratch doesn't use the
format in ways that won't work with QEMU's implementation.
Stefan
next prev parent reply other threads:[~2011-03-08 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 11:47 [Qemu-devel] [PATCH] Add qcow2 documentation Kevin Wolf
2011-03-08 13:13 ` Stefan Hajnoczi
2011-03-08 13:31 ` Kevin Wolf
2011-03-08 13:48 ` Stefan Hajnoczi [this message]
2011-03-09 18:08 ` Dushyant Bansal
2011-03-09 21:46 ` Stefan Hajnoczi
2011-03-10 8:12 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinjMFoBXtxLaQobVRmq7EkOpiM_Dt0R8NQwcWmf@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).