From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50220 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PkEnN-0002OQ-8I
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 06:53:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PkEnL-0001n8-Sx
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 06:53:17 -0500
Received: from mail-fx0-f45.google.com ([209.85.161.45]:36985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PkEnL-0001n0-N7
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 06:53:15 -0500
Received: by fxm12 with SMTP id 12so6931527fxm.4
	for <qemu-devel@nongnu.org>; Tue, 01 Feb 2011 03:53:14 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <6ADF7310-2588-4FD5-BA21-2A31456B3E2B@suse.de>
References: <1295864581-13494-1-git-send-email-vapier@gentoo.org>
	<20110131140054.GA24608@edde.se.axis.com>
	<AANLkTi=QMN9CfWn9PnDhuA4e-pJF5-xJdmC-kQc67No_@mail.gmail.com>
	<929A8BC2-BC8C-459D-96C0-FF8E9C1BF5FD@suse.de>
	<AANLkTi=E+14FZ9-kJyhST3WN=afJ6Du-2w_0pD2kMqXj@mail.gmail.com>
	<6ADF7310-2588-4FD5-BA21-2A31456B3E2B@suse.de>
Date: Tue, 1 Feb 2011 11:53:14 +0000
Message-ID: <AANLkTinpgL1xUzk7_fqMwyV2fB0=5vd0c9gEUC42ncsm@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Mike Frysinger <vapier@gentoo.org>, toolchain-devel@blackfin.uclinux.org, qemu-devel@nongnu.org

On 1 February 2011 11:46, Alexander Graf <agraf@suse.de> wrote:

> Ouch. Yes. General rule: never access env from translate.c :).

With the arm target I was tempted to restructure translate.c so
that we copied the handful of "safe" bits of env that we used
into the disas context struct right at the start, and then didn't
pass env into the main translation functions at all. That would
make it much harder to accidentally use bits of env that we
should not, but in the end I decided against it because it would
make my qemu-meego merging job that much harder...

-- PMM