From: Blue Swirl <blauwirbel@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL] pci, vhost fixes
Date: Sun, 30 May 2010 18:19:40 +0000 [thread overview]
Message-ID: <AANLkTinseMLzGGS9N-bc8djjEQIfcC_i-sJRereCCIiv@mail.gmail.com> (raw)
In-Reply-To: <20100530180545.GA30132@redhat.com>
On Sun, May 30, 2010 at 6:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Sun, May 30, 2010 at 04:56:11PM +0000, Blue Swirl wrote:
>> On Sun, May 30, 2010 at 3:50 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > The following changes since commit 259d5577ae546de27e25a40710f81aa031660de8:
>> >
>> > lsi: Fix value overflow in request tag processing (2010-05-22 15:32:32 +0200)
>> >
>> > are available in the git repository at:
>> > git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
>> >
>> > Isaku Yamahata (4):
>> > pci: clean up of pci_set_default_subsystem_id().
>> > pci: add const to pci_is_express(), pci_config_size().
>> > pci.h: remove unused constants.
>> > msix: remove duplicated defines.
>> >
>> > Michael S. Tsirkin (1):
>> > vhost: fix build broken by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
>>
>> Nack, see 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb.
>
> Did you follow the discussion about that patch before applying?
> 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb does not make sense
> to me, I think it should be reverted.
> we have long long value, let us just print with %ll.
> casting to uint64 and printing with PRi64 is silly.
We have PRI*64 just for this purpose, so let's use them. The
discussion about that was earlier.
next prev parent reply other threads:[~2010-05-30 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 15:50 [Qemu-devel] [PULL] pci, vhost fixes Michael S. Tsirkin
2010-05-30 16:56 ` Blue Swirl
2010-05-30 18:05 ` Michael S. Tsirkin
2010-05-30 18:19 ` Blue Swirl [this message]
2010-05-30 18:58 ` Michael S. Tsirkin
2010-05-30 19:15 ` Blue Swirl
2010-05-31 12:51 ` [Qemu-devel] " Paolo Bonzini
2010-05-31 13:35 ` Michael S. Tsirkin
2010-05-31 18:29 ` Blue Swirl
2010-06-01 5:32 ` Markus Armbruster
2010-06-01 17:13 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinseMLzGGS9N-bc8djjEQIfcC_i-sJRereCCIiv@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).