From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36264 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OIn7D-0001tb-Rl
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:20:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OIn7B-0004yf-Nv
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:20:02 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:33536)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OIn7B-0004yZ-IF
	for qemu-devel@nongnu.org; Sun, 30 May 2010 14:20:01 -0400
Received: by pwi7 with SMTP id 7so507133pwi.4
	for <qemu-devel@nongnu.org>; Sun, 30 May 2010 11:20:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100530180545.GA30132@redhat.com>
References: <20100530155000.GA30051@redhat.com>
	<AANLkTin--RkgbbJVDOLLn4NC3Xi8MnBq4L38IZiAxEMN@mail.gmail.com>
	<20100530180545.GA30132@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 30 May 2010 18:19:40 +0000
Message-ID: <AANLkTinseMLzGGS9N-bc8djjEQIfcC_i-sJRereCCIiv@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL] pci, vhost fixes
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Sun, May 30, 2010 at 6:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Sun, May 30, 2010 at 04:56:11PM +0000, Blue Swirl wrote:
>> On Sun, May 30, 2010 at 3:50 PM, Michael S. Tsirkin <mst@redhat.com> wro=
te:
>> > The following changes since commit 259d5577ae546de27e25a40710f81aa0316=
60de8:
>> >
>> > =C2=A0lsi: Fix value overflow in request tag processing (2010-05-22 15=
:32:32 +0200)
>> >
>> > are available in the git repository at:
>> > =C2=A0git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
>> >
>> > Isaku Yamahata (4):
>> > =C2=A0 =C2=A0 =C2=A0pci: clean up of pci_set_default_subsystem_id().
>> > =C2=A0 =C2=A0 =C2=A0pci: add const to pci_is_express(), pci_config_siz=
e().
>> > =C2=A0 =C2=A0 =C2=A0pci.h: remove unused constants.
>> > =C2=A0 =C2=A0 =C2=A0msix: remove duplicated defines.
>> >
>> > Michael S. Tsirkin (1):
>> > =C2=A0 =C2=A0 =C2=A0vhost: fix build broken by 0bfcd599e3f5c5679cc7d01=
65a0a1822e2f60de2
>>
>> Nack, see 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb.
>
> Did you follow the discussion about that patch before applying?
> 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb does not make sense
> to me, I think it should be reverted.
> we have long long value, let us just print with %ll.
> casting to uint64 and printing with PRi64 is silly.

We have PRI*64 just for this purpose, so let's use them. The
discussion about that was earlier.