From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53397 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OsGop-0006wg-Gs for qemu-devel@nongnu.org; Sun, 05 Sep 2010 11:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OsGo0-0000XD-IX for qemu-devel@nongnu.org; Sun, 05 Sep 2010 11:06:53 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:34507) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OsGo0-0000UM-GS for qemu-devel@nongnu.org; Sun, 05 Sep 2010 11:06:52 -0400 Received: by mail-qy0-f180.google.com with SMTP id 31so3889321qyk.4 for ; Sun, 05 Sep 2010 08:06:52 -0700 (PDT) MIME-Version: 1.0 From: Blue Swirl Date: Sun, 5 Sep 2010 15:06:32 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] [PATCH 08/15] blkdebug: fix enum comparison List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel The signedness of enum types depend on the compiler implementation. Therefore the check for negative values may or may not be meaningful. Fix by explicitly casting to a signed integer. Since the values are also checked earlier against event_names table, this is an internal error. Change the 'if' to 'assert'. This also fixes a warning with GCC flag -Wtype-limits. Signed-off-by: Blue Swirl --- block/blkdebug.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2a63df9..4d6ff0a 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -439,9 +439,7 @@ static void blkdebug_debug_event(BlockDriverState *bs, BlkDebugEvent event) struct BlkdebugRule *rule; BlkdebugVars old_vars = s->vars; - if (event < 0 || event >= BLKDBG_EVENT_MAX) { - return; - } + assert((int)event >= 0 && event < BLKDBG_EVENT_MAX); QLIST_FOREACH(rule, &s->rules[event], next) { process_rule(bs, rule, &old_vars); -- 1.6.2.4