From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35389 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3uL6-0006Ut-1l
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:33:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P3uL4-0003im-UG
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:33:07 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:45462)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P3uL4-0003iZ-Qe
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:33:06 -0400
Received: by qyk4 with SMTP id 4so816554qyk.4
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 10:33:06 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4CAD7657.8080400@redhat.com>
References: <AANLkTinWu7ABrSP9EVZFeC==+ZS+qDOur8rAPNjdzo6i@mail.gmail.com>
	<4CAD7657.8080400@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 7 Oct 2010 17:32:45 +0000
Message-ID: <AANLkTinuzdGp_O7cXxebSiqipN2vW_r9TpiDJYkA9oH6@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 10/06/2010 11:34 PM, Blue Swirl wrote:
>>
>> Compiling with GCC 4.6.0 20100925 produced warnings:
>> /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
>> /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
>> set but not used [-Werror=unused-but-set-variable]
>>
>> Fix by deleting the variable.
>
> Again, this warning tells us the emulation is incorrect, so it's wrong to
> remove it.

The warning tells us that the emulation is unfinished.

It's probably unfinished because debugging TSS switches hasn't ever
been needed by anyone. If anyone in the future cares enough about T
bit, it's easy to implement it even after this part has been removed.

But if someone proposes a better patch, I'd be happy to use that
instead of this.