From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49316 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJUB7-00069f-HH for qemu-devel@nongnu.org; Tue, 01 Jun 2010 12:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJUB5-00030i-RG for qemu-devel@nongnu.org; Tue, 01 Jun 2010 12:18:57 -0400 Received: from mail-yw0-f197.google.com ([209.85.211.197]:37510) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJUB5-00030Z-P1 for qemu-devel@nongnu.org; Tue, 01 Jun 2010 12:18:55 -0400 Received: by ywh35 with SMTP id 35so4555204ywh.29 for ; Tue, 01 Jun 2010 09:18:50 -0700 (PDT) MIME-Version: 1.0 Sender: tamura.yoshiaki@gmail.com In-Reply-To: <4C052E0C.4000804@linux.vnet.ibm.com> References: <1275406821-30024-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4C052E0C.4000804@linux.vnet.ibm.com> Date: Wed, 2 Jun 2010 01:18:48 +0900 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 0/4] Threaded tcp incoming migration. From: Yoshiaki Tamura Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org 2010/6/2 Anthony Liguori : > On 06/01/2010 10:40 AM, Yoshiaki Tamura wrote: >> >> Hi, >> >> This series add threaded tcp incoming migration. =A0Currently, tcp migra= tion >> on >> incoming side is blocked when outgoing has started on the remote side, a= nd >> you >> can't do anything. =A0With this series you can get info of incoming >> migration by >> calling "info migrate" like on outgoing side. =A0Threaded tcp incoming >> migration >> is enable only when --enable-io-thread is set. >> > > I'm much less confident that threading is the answer here. =A0We really w= ould > just need to have asynchronous incoming migration. You mean, go back to select() in main(), and then call incoming handler each time? Won't it introduce more latency, resulting less throughput? Although threading maybe a big hammer for just getting monitor working, I think using thread for incoming handler may worth if it doesn't heart performance on receiving data. The downside is mutual exclusion, of course... Thanks, Yoshi > > Regards, > > Anthony Liguori > >> This series apply on top of patch from Corentin posted on May 29. >> >> http://www.mail-archive.com/qemu-devel@nongnu.org/msg33830.html >> >> Yoshiaki Tamura (4): >> =A0 qemu-thread: add qemu_thread_join(). >> =A0 migration-tcp: threaded tcp incoming migration. >> =A0 arch_init: calculate transferred bytes at ram_load(). >> =A0 migration: add support to print migration info on incoming side. >> >> =A0arch_init.c =A0 =A0 | =A0 =A02 + >> =A0migration-tcp.c | =A0 86 >> ++++++++++++++++++++++++++++++++++++++++++++++--------- >> =A0migration.c =A0 =A0 | =A0 18 +++++++++-- >> =A0migration.h =A0 =A0 | =A0 =A02 +- >> =A0qemu-thread.c =A0 | =A0 =A09 ++++++ >> =A0qemu-thread.h =A0 | =A0 =A01 + >> =A06 files changed, 99 insertions(+), 19 deletions(-) >> >> > > >